Boost C++ Libraries: Ticket #3634: to_upper / to_lower incorrect for machines with signed chars

attachment set

Wed, 18 Nov 2009 07:41:41 GMT

attachment → testLocaleBoost.cpp

example demonstrating the problem

status changed

Pavol Droba — Wed, 18 Nov 2009 19:15:59 GMT

status new → assigned

Would you be by any chance able to submit a patch that is tested on solaris? I don't have access to such machine, so I would be fixing blindly.

I will gladly incorporate it into the library code.

attachment set

Thu, 19 Nov 2009 06:35:00 GMT

attachment → dirty_fix.patch

unified diff of a dirty quick-fix

Thu, 19 Nov 2009 06:35:57 GMT

I don't have something you would like to use as I only have a fix that would completely break the locale parameter to the function call. I've attached the patch anyway, maybe you could give me an additional hint what to try instead. (I'm a bit lost between all those facet templates. ;-)

Pavol Droba — Fri, 20 Nov 2009 19:35:51 GMT

Looking at the problem again, I think that the problem actually lies in Solaris's C++ locales. There is nothing wrong with chars being signed.

Anyway, I'll try to check it out and come up with a solution.

Mon, 23 Nov 2009 08:05:02 GMT

Thanks! If you have something ready, feel free to contact me to test it.

owner, status, component changed

Marshall Clow — Wed, 28 Dec 2011 18:52:35 GMT

owner changed from Pavol Droba to Marshall Clow
status assigned → new
component string_algo → algorithm

Marshall Clow — Tue, 10 Jan 2012 18:08:02 GMT

Replying to pavol_droba:

Looking at the problem again, I think that the problem actually lies in Solaris's C++ locales. There is nothing wrong with chars being signed.

Anyway, I'll try to check it out and come up with a solution.

I'm coming to that conclusion, too.

The C versions of tolower, et. al. take an int as a parameter. The C99 standard (section 7.4.1) says that the input to tolower needs to be representable as unsigned char, or EOF. To me that means "no negative numbers". Microsoft has a page that talks about this issue, too: http://msdn.microsoft.com/en-us/library/ms245348.aspx

However, the C++ version std::tolower, takes a char (templated) as a parameter, and I can't find any similar restriction in either the C++03 standard or the (draft) C++11 standard. To me, that means that all possible values of char are allowable (or whatever type the function is templated upon)

Marshall Clow — Thu, 12 Jan 2012 18:45:58 GMT

I just checked in a fix in [76435], will merge to release after tests cycle.

status changed; resolution set

Marshall Clow — Sun, 15 Jan 2012 16:05:57 GMT

status new → closed
resolution → fixed

(In [76522]) Merge changes to release; fixes #3634