status changed; resolution set

John Maddock — Sun, 22 Nov 2009 16:38:07 GMT

status new → closed
resolution → fixed

(In [57843]) Fix preprocessor logic for long long support. Fixes #3657. Fixes #3568.

status, version, milestone changed; resolution deleted

abadura@… — Thu, 04 Feb 2010 08:56:48 GMT

status closed → reopened
version Boost 1.41.0 → Boost 1.42.0
resolution fixed
milestone Boost 1.42.0 → Boost 1.43.0

The problem still exists for VS 2005.

It seems there is more then one problem here actually.

Visual C++ configuration is incorrect.

boost/config/compiler/visualc.hpp#128-132

#if (_MSC_VER >= 1310) && (defined(_MSC_EXTENSIONS) || (_MSC_VER >= 1500))
#   define BOOST_HAS_LONG_LONG
#else
#   define BOOST_NO_LONG_LONG
#endif

Visual C++ 2005 (which is _MSC_VER == 1400) also has long long type (regardless whether _MSC_EXTENSIONS is defined or not).

Integer headers are still incorrect.

boost/integer_fwd.hpp#80-86

#if !defined(BOOST_NO_INTEGRAL_INT64_T) && !defined(BOOST_NO_INT64_T) && (defined(BOOST_HAS_LONG_LONG) || defined(BOOST_HAS_MS_INT64))
template <  >
    class integer_traits<  ::boost::long_long_type>;
template <  >
    class integer_traits<  ::boost::ulong_long_type >;
#endif

It seems that BOOST_HAS_MS_INT64 in no way influences existence of ::boost::long_long_type thus it should disappear from the condition because it leads to broken compilation.

Or the other way: it should start influence existence of ::boost::long_long_type. To achieve this preprocessor condition in

boost/config/suffix.hpp#467-477

#if defined(BOOST_HAS_LONG_LONG)
namespace boost{
#  ifdef __GNUC__
   __extension__ typedef long long long_long_type;
   __extension__ typedef unsigned long long ulong_long_type;
#  else
   typedef long long long_long_type;
   typedef unsigned long long ulong_long_type;
#  endif
}
#endif

should include BOOST_HAS_MS_INT64.

Which of those two is correct depends on how all Visual C++ compilers behave. I have only access to 2005 and 2008 so someone else should check it on 2003 and earlier.

In Visual Studio 2008 it seems to be fine now.

status changed; resolution set

John Maddock — Thu, 04 Feb 2010 11:15:56 GMT

status reopened → closed
resolution → fixed

(In [59468]) Change integer code to still work when BOOST_HAS_MS_INT64 is defined but BOOST_HAS_LONG_LONG is not. Update VC++ config to define BOOST_HAS_LONG_LONG for MSVC-8 in ANSI mode. Fixes #3657.

Boost C++ Libraries: Ticket #3657: integer.hpp does not compile in MSVS 8.0 with /Za

status changed; resolution set

status, version, milestone changed; resolution deleted

status changed; resolution set