Boost C++ Libraries: Ticket #3670: endless loop in dev_poll_reactor on Solaris

chris_kohlhoff — Sat, 02 Jan 2010 12:51:17 GMT

I cannot reproduce the problem. However, please try the following fix and report the results:

Index: dev_poll_reactor.hpp =================================================================== --- dev_poll_reactor.hpp (revision 58628) +++ dev_poll_reactor.hpp (working copy) @@ -435,7 +435,6 @@

more_writes = write_op_queue_.has_operation(descriptor);

if ((events[i].events & (POLLERR | POLLHUP)) != 0

&& (events[i].events & ~(POLLERR | POLLHUP)) == 0

&& !more_except && !more_reads && !more_writes)

{

If we have an event and no operations associated with the

dirkmoermans@… — Mon, 04 Jan 2010 13:01:17 GMT

Thanks for the patch. I will try it out as soon as I get access to a solaris box (somewhere next week).

dirkmoermans@… — Wed, 06 Jan 2010 09:11:51 GMT

The patch solves the problem for me.

I dumped some traces with the contents of events[i].events and got as output without the patch in an endless loop:

events[i].events=1c
events[i].events & ~(POLLERR | POLLHUP) = 4

4 corresponds to POLLOUT in sys/poll.h:

#define POLLOUT         0x0004          /* fd is writeable (won't block) */

I don't know why it is not reproducable, but it would be great if you would include your patch in the next boost-release.

chris_kohlhoff — Wed, 06 Jan 2010 12:36:53 GMT

(In [58762]) Apply fix for reported excessive CPU usage under Solaris. Refs #3670.

status changed; resolution set

chris_kohlhoff — Mon, 11 Jan 2010 02:34:08 GMT

status new → closed
resolution → fixed

(In [58883]) Merge from trunk. Fixes #3743, #3670, #3822.

........

r58670 | chris_kohlhoff | 2010-01-04 23:33:04 +1100 (Mon, 04 Jan 2010) | 2 lines

Fix example to compile with MSVC 10 beta 2.

........

r58671 | chris_kohlhoff | 2010-01-04 23:33:42 +1100 (Mon, 04 Jan 2010) | 2 lines

Fix Win64 warnings.

........

r58703 | chris_kohlhoff | 2010-01-05 22:51:41 +1100 (Tue, 05 Jan 2010) | 3 lines

Include boost/limits.hpp rather than <limits>, to support older compilers. Refs #3743.

........

r58704 | chris_kohlhoff | 2010-01-05 23:20:10 +1100 (Tue, 05 Jan 2010) | 2 lines

Drop back to second_clock if microsec_clock is unavailable. Refs #3743.

........

r58705 | chris_kohlhoff | 2010-01-05 23:50:39 +1100 (Tue, 05 Jan 2010) | 2 lines

Use sockatmark if SIOCATMARK is not defined. Refs #3743.

........

r58740 | chris_kohlhoff | 2010-01-06 13:38:39 +1100 (Wed, 06 Jan 2010) | 2 lines

Use buffer debugging workaround with MSVC 8 only.

........

r58761 | chris_kohlhoff | 2010-01-06 23:27:05 +1100 (Wed, 06 Jan 2010) | 2 lines

Disable iostreams-related functionality if BOOST_NO_IOSTREAMS is defined. Refs #3743.

........

r58762 | chris_kohlhoff | 2010-01-06 23:36:51 +1100 (Wed, 06 Jan 2010) | 2 lines

Apply fix for reported excessive CPU usage under Solaris. Refs #3670.

........

r58782 | chris_kohlhoff | 2010-01-07 09:44:48 +1100 (Thu, 07 Jan 2010) | 2 lines

Disable handler allocation and invocation hooks on g++ 2.x. Refs #3743.

........

r58793 | chris_kohlhoff | 2010-01-08 09:18:16 +1100 (Fri, 08 Jan 2010) | 2 lines

Support platforms that don't define INET6_ADDRSTRLEN. Refs #3743.

........