Boost C++ Libraries: Ticket #3678: Build failure on SPARC64 architecture

Peter Dimov — Thu, 26 Nov 2009 18:21:23 GMT

(In [57949]) Fix SPARC asm operand failure. Refs #3678. Refs #3341.

status changed

Peter Dimov — Thu, 26 Nov 2009 18:25:39 GMT

status new → assigned

It is normal for spinlock_try_test to fail in single-threaded mode. I've committed the patch to trunk. But there are two more tests whose results I'd like to see, shared_ptr_mt_test.cpp and weak_ptr_mt_test.cpp. They are not part of the Jamfile though, and need to be compiled and run manually.

churanov.port.maintainer@… — Fri, 27 Nov 2009 14:00:18 GMT

Peter,

I've created a makefile to build and run the three tests with proper compiler settings. Could you examine the makefile and log and confirm that compiler flags are correct and tests are actually passing?

The machine is a SMP sparc64 (4 x 300 MHz).

External files: The patch - http://alexanderchuranov.com/boost-port/boost-1.41-sparc64/patch-boost_smart_ptr_detail_sp_counted_base_gcc_sparc.hpp
The makefile - http://alexanderchuranov.com/boost-port/boost-1.41-sparc64/Makefile
The output of "make test" - http://alexanderchuranov.com/boost-port/boost-1.41-sparc64/bjam-1.41-make-test.log

Alexander Churanov

Peter Dimov — Fri, 27 Nov 2009 14:49:36 GMT

Everything looks fine. Can you please try the same at -O2 or -O3, and without -fno-inline?

churanov.port.maintainer@… — Mon, 30 Nov 2009 17:25:47 GMT

Peter,

I've modified the makefile to accept optimization options on invocation and run with OPTIMIZATION='-O2' and OPTIMIZATION='-O3'. The output is much like the previous one (with -O0).

External files:

Makefile - http://alexanderchuranov.com/boost-port/boost-1.41-sparc64/Makefile2
Log with -O2 - http://alexanderchuranov.com/boost-port/boost-1.41-sparc64/smart_ptr_O2_test.log
Log with -O3 - http://alexanderchuranov.com/boost-port/boost-1.41-sparc64/smart_ptr_O3_test.log

Does this output mean that it is safe to check-in the patch?

Alexander Churanov

Peter Dimov — Mon, 30 Nov 2009 17:52:05 GMT

The patch is already checked into trunk. I will now merge it into the release branch; the tests look OK.

anonymous — Mon, 30 Nov 2009 18:58:12 GMT

I was meaning checking into the FreeBSD ports repository. :-) I'm sure that the next release of Boost will contain the patch. And I'm going to provide patches for 1.39 and 1.41 on FreeBSD.

Thank you for cooperation!

status changed; resolution set

Peter Dimov — Mon, 30 Nov 2009 20:17:16 GMT

status assigned → closed
resolution → fixed

(In [58063]) Merge [57949] to release. Fixes #3678. Fixes #3341.