Boost C++ Libraries: Ticket #3901: ASIO and macro min and max on Windows

jan.boehme@… — Sat, 13 Feb 2010 18:16:41 GMT

This is an issue asio shouldn't care about. Just <define>NOMINMAX when building on this platform.

habdank@… — Mon, 15 Feb 2010 12:47:16 GMT

Hi,

To be honest I disagree that it is not a matter of ASIO.

This is a matter of good encapsulation. Inclusion of the windows.h is a private matter of ASIO. Even more if ASIO would use PIMPL idiom maybe no one would be affected by that macros.

Also consider that if ASIO will stop using windows.h for some reasons, any code will be still affected - then by having useless undefs or NOMINMAX build flag.

As I told that macros are conflicting with standard C++.

Off course I could build my software with NOMINMAX flag or do the #undef on my own :-).

Best regards, Seweryn Habdank-Wojewodzki.

chris_kohlhoff — Thu, 18 Mar 2010 01:33:55 GMT

Fixed on trunk in changeset [60681].

anonymous — Thu, 18 Mar 2010 16:08:27 GMT

Replying to chris_kohlhoff:

Fixed on trunk in changeset [60681].

Thanks!

status changed; resolution set

chris_kohlhoff — Sun, 21 Mar 2010 09:39:29 GMT

status new → closed
resolution → fixed

(In [60741]) Merge from trunk.

........

r60681 | chris_kohlhoff | 2010-03-18 12:32:34 +1100 (Thu, 18 Mar 2010) | 3 lines

Define NOMINMAX for all Windows compilers, not just Cygwin. Users can define BOOST_ASIO_NO_NOMINMAX to suppress this definition. Fixes #3901.

........

r60687 | chris_kohlhoff | 2010-03-18 17:23:38 +1100 (Thu, 18 Mar 2010) | 4 lines

Use a bitmask type for the resolver flags, as per the TR2 proposal. This will prevent implicit conversion from int to flags, allowing the compiler to catch cases where users incorrectly pass a numeric port number as the service name.

........

r60689 | chris_kohlhoff | 2010-03-18 22:08:19 +1100 (Thu, 18 Mar 2010) | 2 lines

Fix bug where 0-byte reads were incorrectly passing an eof error_code to the handler. Fixes #4023.

........

r60705 | chris_kohlhoff | 2010-03-20 00:08:04 +1100 (Sat, 20 Mar 2010) | 3 lines

Fix epoll_reactor bug where cancelled operations would complete with a "success" error_code.

........

r60717 | chris_kohlhoff | 2010-03-20 10:23:28 +1100 (Sat, 20 Mar 2010) | 2 lines

More extensive read and write tests.

........

r60722 | chris_kohlhoff | 2010-03-20 10:57:50 +1100 (Sat, 20 Mar 2010) | 2 lines

WinCE doesn't provide InitializeCriticalSectionAndSpinCount.

........

r60723 | chris_kohlhoff | 2010-03-20 10:58:48 +1100 (Sat, 20 Mar 2010) | 2 lines

Fix cancellation.

........

r60725 | chris_kohlhoff | 2010-03-20 10:59:48 +1100 (Sat, 20 Mar 2010) | 3 lines

Use cancel() to avoid Windows behaviour where a connection is reset if the socket is closed while there is a pending read operation.

........