Boost C++ Libraries: Ticket #3908: using boost::gil fails when upgrading to libpng-1.4.0

anonymous — Wed, 04 Aug 2010 21:32:25 GMT

Done. Ticket is closed.

status changed; resolution set

chhenning — Thu, 05 Aug 2010 14:55:07 GMT

status new → closed
resolution → fixed

status changed; resolution deleted

Bryce Adelstein Lelbach — Thu, 17 Mar 2011 00:04:26 GMT

status closed → reopened
resolution fixed

Reports in IRC indicate this is still a problem.

Bryce Adelstein Lelbach — Thu, 17 Mar 2011 00:17:46 GMT

In file included from /usr/include/boost/gil/extension/io/png_io.hpp:41:0,
                 from ../src/write.cxx:4:
/usr/include/boost/gil/extension/io/png_io_private.hpp: In member function ‘void boost::gil::detail::png_reader_color_convert<CC>::apply(const View&)’:
/usr/include/boost/gil/extension/io/png_io_private.hpp:228:22: error: ‘int_p_NULL’ was not declared in this scope

Reported by ville on IRC (ville3.14159@…).

Build environment:

GCC 4.5.2
Linux 2.6.37 (Arch-Linux distro)
Boost 1.46.0 (Arch-Linux packaged)
libpng 1.4.5-1 (Arch-Linux packaged)

version, milestone changed; cc set

Bryce Adelstein Lelbach — Thu, 17 Mar 2011 00:19:06 GMT

cc blelbach@… added
version Boost 1.42.0 → Boost 1.46.0
milestone Boost 1.43.0 → Boost 1.47.0

anonymous — Wed, 07 Mar 2012 09:01:42 GMT

Hi,

When using boost-1.49.0 with libpng-1.5.9 I also get this:

/xxxxx/w/slc5_amd64_gcc461/external/boost/1.49.0/include/boost/gil/extension/io/png_io_private.hpp: I
n member function 'void boost::gil::detail::png_reader_color_convert<CC>::apply(const View&)':
/xxxxx/w/slc5_amd64_gcc461/external/boost/1.49.0/include/boost/gil/extension/io/png_io_private.hpp:22
8:22: error: 'int_p_NULL' was not declared in this scope

Grepping the boost tree also finds other occurrences:

$ egrep -r 'png_infopp_NULL|int_p_NULL' w/BUILD/slc5_amd64_gcc461/external/boost/1.49.0
w/BUILD/slc5_amd64_gcc461/external/boost/1.49.0/boost_1_49_0/libs/gil/doc/html/g_i_l_0250.html:<a name="l00091"></a>00091                      int_p_NULL, int_p_NULL);
w/BUILD/slc5_amd64_gcc461/external/boost/1.49.0/boost_1_49_0/libs/gil/doc/html/g_i_l_0253.html:<a name="l00155"></a>00155             png_destroy_read_struct(&amp;_png_ptr,png_infopp_NULL,png_infopp_NULL);
w/BUILD/slc5_amd64_gcc461/external/boost/1.49.0/boost_1_49_0/libs/gil/doc/html/g_i_l_0253.html:<a name="l00160"></a>00160             png_destroy_read_struct(&amp;_png_ptr, &amp;_info_ptr, png_infopp_NULL);
w/BUILD/slc5_amd64_gcc461/external/boost/1.49.0/boost_1_49_0/libs/gil/doc/html/g_i_l_0253.html:<a name="l00174"></a>00174         png_destroy_read_struct(&amp;_png_ptr,&amp;_info_ptr,png_infopp_NULL);
w/BUILD/slc5_amd64_gcc461/external/boost/1.49.0/boost_1_49_0/libs/gil/doc/html/g_i_l_0253.html:<a name="l00186"></a>00186                      int_p_NULL, int_p_NULL);
w/BUILD/slc5_amd64_gcc461/external/boost/1.49.0/boost_1_49_0/libs/gil/doc/html/g_i_l_0253.html:<a name="l00228"></a>00228                      int_p_NULL, int_p_NULL);
w/BUILD/slc5_amd64_gcc461/external/boost/1.49.0/boost_1_49_0/libs/gil/doc/html/g_i_l_0253.html:<a name="l00317"></a>00317             png_destroy_write_struct(&amp;_png_ptr,png_infopp_NULL);
w/BUILD/slc5_amd64_gcc461/external/boost/1.49.0/boost_1_49_0/boost/gil/extension/io/png_io_private.hpp:                     int_p_NULL, int_p_NULL);

Could you please confirm that the change png_infopp_NULL|int_p_NULL to NULL would fix the problem?

Cheers, Diego Gomes.

anonymous — Thu, 14 Feb 2013 10:00:29 GMT

I can confirm this problem using Fedora 18 Linux.
boost-devel-1.50.0-4.fc18.x86_64
gcc-4.7.2-8.fc18.x86_64

cc, version, milestone changed; keywords set

yves.pausch@… — Fri, 15 Feb 2013 13:58:23 GMT

cc yves.pausch@… added
keywords gil png libpng incompatible added
version Boost 1.46.0 → Boost 1.53.0
milestone Boost 1.47.0 → Boost 1.54.0

Same here with libpng 1.5.13

cc changed

Mateusz Loskot — Thu, 16 Feb 2017 10:48:47 GMT

cc mateusz@… added

owner, status changed

Stefan Seefeld — Sat, 01 Jul 2017 21:12:28 GMT

owner changed from Hailin Jin to Stefan Seefeld
status reopened → new

status, milestone changed; resolution set

Mateusz Loskot — Thu, 23 Aug 2018 09:43:00 GMT

status new → closed
resolution → fixed
milestone Boost 1.54.0 → Boost 1.68.0

GIL in Boost 1.68 delivers completely re-implemented I/O extensions. The new version does not use the troublesome macros, so the issue should be gone now.

Closing as fixed.

GitHub ref: https://github.com/boostorg/gil/projects/4#card-12368324