Boost C++ Libraries: Ticket #3972: Broken support for unordered sets and multisets in adjacency_list graphs

attachment set

Wed, 03 Mar 2010 14:03:18 GMT

attachment → unordered-adjacency_list.patch

Patch that solves the described issue.

attachment set

Wed, 03 Mar 2010 14:30:45 GMT

attachment → unordered-adjacency_list.2.patch

Sorry, the previous patch has a minor bug. This one is correct.

owner, status changed

Jeremiah Willcock — Wed, 03 Mar 2010 17:19:15 GMT

owner changed from Andrew Sutton to Jeremiah Willcock
status new → assigned

I agree with your bug. Could you please change the copyright message to you, though, since your patch adds so much code? With that I think I can apply it soon.

attachment set

Fri, 05 Mar 2010 11:03:10 GMT

attachment → unordered-adjacency_list.3.patch

Same as unordered-adjacency_list.2.patch with updated copyright notices.

Fri, 05 Mar 2010 11:03:57 GMT

Replying to jewillco:

Could you please change the copyright message to you, though, since your patch adds so much code?

Sure. Here is a new patch. It adds a copyright line with my name and current year. Is this OK, or should I rather modify the existing lines?

status changed; resolution set

Jeremiah Willcock — Fri, 05 Mar 2010 18:27:45 GMT

status assigned → closed
resolution → fixed

(In [60198]) Added in container_traits and adjacency_list patches to fix unordered container issues (patch from #3972); fixes #3972

Jeremiah Willcock — Fri, 05 Mar 2010 18:29:01 GMT

This should be fixed now -- I moved the equal_range stuff to container_traits, and it turns out that the iterators are actually unstable, not stable as was in the patch.

attachment set

Thu, 18 Mar 2010 23:57:01 GMT

attachment → unordered_equal_range_dispatch.patch

Fix equal_range dispatch and container categories

status changed; cc set; resolution deleted

Fri, 19 Mar 2010 00:04:35 GMT

cc i@… added
status closed → reopened
resolution fixed

The actual dispatch functions for equal_range, as per r60698, don't work as expected. As a result std::equal_range is always used. The default dispatch function should take a container_tag as argument and not a template parameter, since the latter always takes precedence.

Besides, unordered_{set,multiset,map,multimap} should have their own tags which aren't subclasses of sorter_associative_container_tag.

The attached patch corrects those two issues.

Jeremiah Willcock — Sun, 28 Mar 2010 18:00:31 GMT

Could you please add a copyright notice with your name at the top of the file (i.e., rebuild your patch with that change) rather than updating the year on the existing notice? I should be able to apply your patch after that. Thank you.

attachment set

i@… — Sun, 28 Mar 2010 18:56:53 GMT

attachment → unordered_equal_range_dispatch.2.patch

Corrected copyright lines.

status changed; resolution set

Jeremiah Willcock — Fri, 02 Apr 2010 15:06:14 GMT

status reopened → closed
resolution → fixed

(In [60999]) Applied another patch (unordered_equal_range_dispatch.2.patch) from #3972; fixes #3972