Boost C++ Libraries: Ticket #4014: [PATCH] boost/gil gcc warning cleanup

attachment set

Mon, 15 Mar 2010 20:53:18 GMT

attachment → boost_gil_gcc_warning_cleanup.diff

cc set

Mateusz Loskot — Thu, 16 Feb 2017 10:54:04 GMT

cc mateusz@… added

owner changed

Stefan Seefeld — Sat, 01 Jul 2017 21:12:46 GMT

owner changed from Hailin Jin to Stefan Seefeld

cc changed

Mateusz Loskot — Mon, 25 Jun 2018 13:23:24 GMT

cc Mateusz Loskot added

attachment set

Mateusz Loskot — Sat, 25 Aug 2018 07:54:06 GMT

attachment → build.7z

Complete build log generated by b2 toolset=gcc using GCC 7.3 and all the compilation flags suggested by the ticket's reporter

status changed; resolution set

Mateusz Loskot — Sat, 25 Aug 2018 07:57:20 GMT

status new → closed
resolution → fixed

Most of the warnings cleaned by the patch are -Wshadow diagnostics for constructor parameter/class member of the same name. Use of the same constructor parameter/class member names is fine C++ and I don't think we need any changes here.

I attached complete build log generated by b2 toolset=gcc using GCC 7.3 and all the compilation flags suggested by the ticket's reporter and I no longer see any

warning: declaration of ... shadows a member of...

related to the suggested patch.

As for the io_error function, it also seems no longer necessary. BTW, GIL in Boost 1.68 delivers completely re-implemented I/O extensions. The new version does provide custom error_exit which does not call hard exit() to abort the application, so the issue should be gone now.

Closing as fixed.

github ref: https://github.com/boostorg/gil/projects/4#card-12435867