Boost C++ Libraries: Ticket #4015: [PATCH] boost/program_options gcc warning cleanup

attachment set

Mon, 15 Mar 2010 20:55:40 GMT

attachment → boost_program_options_gcc_warning_cleanup.diff

Vladimir Prus — Mon, 15 Mar 2010 21:09:04 GMT

Sorry, but I think that whatever warning option causes gcc to warn about "v(v)" style of member initializers is a broken warning option.

Steven Watanabe — Mon, 15 Mar 2010 21:18:32 GMT

I'm guessing that it's -Wshadow.

description changed

Marshall Clow — Mon, 15 Mar 2010 21:24:52 GMT

description modified (diff)

Really? I would have guessed -Winit_self.

Steven Watanabe — Mon, 15 Mar 2010 21:32:05 GMT

No, they're different v's. There's both a member and a parameter called v.

Tue, 16 Mar 2010 19:50:54 GMT

The option causing the warning is indeed -Wshadow. The warnings are caused simply by function parameters that are of the same name as class members.

I'm using that option all the time to prevent myself from doing anything stupid, but its Vladimir's library and if he disagrees, then that's pretty much that. Then just conclude this with 'wontfix'.

And if thus, is there a GCC option that can have it ignore warnings inside certain headers or is the only option to do a lot of script magic?

status changed; resolution set

Vladimir Prus — Wed, 26 May 2010 10:40:37 GMT

status new → closed
resolution → fixed

(In [62236]) Fix -Wshadow warnings. Closes #4015. Patch from Tatu Kilappa.

Vladimir Prus — Wed, 26 May 2010 10:42:22 GMT

While I hate warning options that are broken, -Wshadow seems generally useful to catch issues, so I've applied the patch.

tatu.kilappa@… — Thu, 27 May 2010 18:07:25 GMT

Thanks, I appreciate this.