Opened 13 years ago

Last modified 12 years ago

#4015 closed Patches

[PATCH] boost/program_options gcc warning cleanup — at Version 3

Reported by: Tatu Kilappa <tatu.kilappa@…> Owned by: Vladimir Prus
Milestone: Boost 1.43.0 Component: program_options
Version: Boost Development Trunk Severity: Cosmetic
Keywords: gcc warning Cc:

Description (last modified by Marshall Clow)

Patch to clean up excessive gcc 4.x warning barf.

To reproduce, compile any program_options-using program with: -Wall -Wcast-align -Wconversion -Wdisabled-optimization -Werror=return-type -Wextra -Winit-self -Winvalid-pch -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wno-multichar -Wpacked -Wredundant-decls -Wshadow -Wswitch-default -Wundef -Wwrite-strings -Wctor-dtor-privacy -Werror=non-virtual-dtor -Woverloaded-virtual

Attached patch fixes the issue.

Change History (4)

by Tatu Kilappa <tatu.kilappa@…>, 13 years ago

Attachment: boost_program_options_gcc_warning_cleanup.diff​ added

comment:1 by Vladimir Prus, 13 years ago

Sorry, but I think that whatever warning option causes gcc to warn about "v(v)" style of member initializers is a broken warning option.

comment:2 by Steven Watanabe, 13 years ago

I'm guessing that it's -Wshadow.

comment:3 by Marshall Clow, 13 years ago

Description: modified (diff)

Really? I would have guessed -Winit_self.

Note: See TracTickets for help on using tickets.