https://svn.boost.org/trac10/ticket/4024 <p> Joern Ungermann proposed a patch to improve performance of inplace_solve. </p> <p> The inplace_solve routine has to cope for 24 different cases: </p> <p> a) row_major / column_major </p> <p> b) upper / lower </p> <p> c) dense / packed / sparse </p> <p> d) A * x = b / x * A = b </p> <p> The case row_major / lower_tag / A * x = b is currently mapped to row_major / upper_tag / x * A = b and the case row_major / upper_tag / A * x = b is currently mapped to row_major / lower_tag / x * A = b This is very inefficient for compressed_matrix types! The cases column_major / [lower_tag | upper_tag] / x * A = b are seemingly handled, but I can't get it to complile. The cases of row_major / [lower_tag | upper_tag] / x * A = b *do* have an efficient implementation, which is *not* used to a programming bug, i.e. making the choice of the function depending on the storage type of the vector and not on the matrix. </p> <p> I rewrote triangular.hpp to </p> <p> a) handle *all* cases of A * x = b and to </p> <p> b) "redirect" the x * A = b cases to the aforementioned ones. </p> <p> This keeps the code about the same size as it currently is. It costs some efficiently for the redirected cases, but previously certain cases were also redirected (just different ones). It is trivial to add the missing cases, but adds quite a bit of code. </p> <pre class="wiki"> old (dense) new (dense) old (sparse) new (sparse) col_low x: 3240000 3240000 10000 10000 row_low x: 5100000 3720000 2590000 10000 col_upp x: 3320000 3340000 10000 10000 row_upp x: 5120000 3750000 2790000 10000 x col_low: - 4660000 - 10000 x row_low: 3330000 4060000 3750000 20000 x col_upp: - 5110000 - 20000 x row_upp: 3230000 3910000 3750000 10000 with dense=ublas::matrix and sparse=ublas::compressed_matrix </pre> en-us /htdocs/site/boost.png https://svn.boost.org/trac10/ticket/4024 Trac 1.4.3 Gunter Wed, 17 Mar 2010 20:59:33 GMT https://svn.boost.org/trac10/ticket/4024 https://svn.boost.org/trac10/ticket/4024 <ul> <li><strong>attachment</strong> → <span class="trac-field-new">patch_and_test.tgz</span> </li> </ul> <p> patch provided by Jörn </p> Ticket j.ungermann@… Thu, 18 Mar 2010 07:33:48 GMT https://svn.boost.org/trac10/ticket/4024 https://svn.boost.org/trac10/ticket/4024 <ul> <li><strong>attachment</strong> → <span class="trac-field-new">test_inplace_solve.cc</span> </li> </ul> <p> Test case for inplace solve. </p> Ticket j.ungermann@… Thu, 18 Mar 2010 07:37:40 GMT https://svn.boost.org/trac10/ticket/4024#comment:2 https://svn.boost.org/trac10/ticket/4024#comment:2 <ul> <li><strong>cc</strong> <span class="trac-author">consulting@…</span> added </li> </ul> Ticket Gunter Mon, 27 Aug 2012 22:13:28 GMT https://svn.boost.org/trac10/ticket/4024#comment:9 https://svn.boost.org/trac10/ticket/4024#comment:9 <ul> <li><strong>owner</strong> changed from <span class="trac-author">David Bellot</span> to <span class="trac-author">Gunter</span> </li> <li><strong>status</strong> <span class="trac-field-old">new</span> → <span class="trac-field-new">assigned</span> </li> <li><strong>milestone</strong> <span class="trac-field-old">Boost 1.43.0</span> → <span class="trac-field-new">Boost 1.52.0</span> </li> </ul> Ticket Gunter Sat, 22 Sep 2012 21:58:00 GMT https://svn.boost.org/trac10/ticket/4024#comment:10 https://svn.boost.org/trac10/ticket/4024#comment:10 <ul> <li><strong>status</strong> <span class="trac-field-old">assigned</span> → <span class="trac-field-new">closed</span> </li> <li><strong>resolution</strong> → <span class="trac-field-new">fixed</span> </li> </ul> <p> (In <a class="changeset" href="https://svn.boost.org/trac10/changeset/80645" title="merged ...">[80645]</a>) merged <a class="changeset" href="https://svn.boost.org/trac10/changeset/80483" title=" boost/numeric/ublas/traits.hpp, ...">[80483]</a>,<a class="changeset" href="https://svn.boost.org/trac10/changeset/80487" title="* boost/numeric/ublas/matrix_sparse.hpp: see #7363, add new define ...">[80487]</a>,<a class="changeset" href="https://svn.boost.org/trac10/changeset/80586" title=" * libs/numeric/ublas/test/Jamfile.v2: see #7363 - separate test of ...">[80586]</a>,<a class="changeset" href="https://svn.boost.org/trac10/changeset/80591" title=" * boost/numeric/ublas/vector_sparse.hpp: add ifdef ...">[80591]</a>,<a class="changeset" href="https://svn.boost.org/trac10/changeset/80592" title=" * boost/numeric/ublas/operation/size.hpp: apply patch, see #5812 ">[80592]</a>,<a class="changeset" href="https://svn.boost.org/trac10/changeset/80599" title=" * libs/numeric/ublas/test/test_triangular.cpp - remove unused ...">[80599]</a>,<a class="changeset" href="https://svn.boost.org/trac10/changeset/80600" title=" * libs/numeric/ublas/test/utils.hpp: use 'using ::std' instead of ...">[80600]</a>,<a class="changeset" href="https://svn.boost.org/trac10/changeset/80624" title=" * libs/numeric/ublas/test/utils.hpp: switch to boost::math::isnan, ...">[80624]</a>,<a class="changeset" href="https://svn.boost.org/trac10/changeset/80625" title=" * boost/numeric/ublas/vector_sparse.hpp, ...">[80625]</a>,<a class="changeset" href="https://svn.boost.org/trac10/changeset/80643" title=" * boost/numeric/ublas/storage.hpp: see #7363, remove ...">[80643]</a>,<a class="changeset" href="https://svn.boost.org/trac10/changeset/80644" title=" * libs/numeric/ublas/test/test_triangular.cpp: switch to boost::timer ...">[80644]</a> into release: </p> <ul><li>fix <a class="closed ticket" href="https://svn.boost.org/trac10/ticket/4024" title="#4024: Patches: improve performance of inplace_solve (closed: fixed)">#4024</a> </li></ul><ul><li>fix <a class="closed ticket" href="https://svn.boost.org/trac10/ticket/5812" title="#5812: Patches: Ill formed use of template keyword in qualified names (closed: fixed)">#5812</a> </li></ul><ul><li>fix <a class="closed ticket" href="https://svn.boost.org/trac10/ticket/7296" title="#7296: Bugs: Bug-fix and improvements to test utility functions (closed: fixed)">#7296</a> (hopefully ;-) </li></ul><ul><li>see <a class="closed ticket" href="https://svn.boost.org/trac10/ticket/7363" title="#7363: Bugs: coordinate_matrix::sort() fails with gcc 4.7 (closed: fixed)">#7363</a> (must wait for a full test cycle before closing this task) </li></ul> Ticket