id	summary	reporter	owner	description	type	status	milestone	component	version	severity	resolution	keywords	cc
4139	gcd_integer in common_factor_rt.hpp fails to compile for some IntegerTypes (like mpz_class)	mitchnull@…	John Maddock	"The use of the ternary operator in gcd_integer in common_factor_rt.hpp:119 can lead to compile time error if the unary operator- of the given type doesn't return the same type as itself:

return ( result < zero ) ? -result : result;

as the type of ""-result"" and ""result"" differs.

Either a static_cast is needed like:

return ( result < zero ) ? static_cast<IntegerType>(-result) : result;

or the one-liner should be replaced with an if like this:

        if ( result < zero )
        {
            return -result;
        }
        else
        {
            return result;
        }
"	Bugs	closed	To Be Determined	math	Boost Development Trunk	Problem	fixed	gcd_integer