Boost C++ Libraries: Ticket #4199: Sun Studio compilation of sp_typeinfo.hpp

attachment set

nstewart@… — Fri, 07 May 2010 20:18:19 GMT

attachment → boost_detail_typeinfo_SunPro.diff

Patch for boost/detail/sp_typeinfo.hpp

component changed; owner set

Steven Watanabe — Sat, 08 May 2010 18:29:00 GMT

owner set to Peter Dimov
component None → smart_ptr

Peter Dimov — Wed, 26 May 2010 17:44:00 GMT

(In [62245]) Applied patch for Sun C++. Refs #4199.

status changed; resolution set

Peter Dimov — Sat, 10 Jul 2010 20:46:55 GMT

status new → closed
resolution → fixed

(In [63825]) Merge [62245] to release. Fixes #4199.

status changed; resolution deleted

Tobias Loew — Sun, 29 Aug 2010 10:04:33 GMT

status closed → reopened
resolution fixed

After the change the following code doesn't compile anymore on my VC 9 compiler:

#define BOOST_NO_TYPEID
#include <boost/smart_ptr.hpp>
#include <boost/make_shared.hpp>
struct test {
    test(){}
    int i;
};
int main(int argc, char* argv[])
{
    boost::shared_ptr<test> spt = boost::make_shared<test>();
    return 0;
}

the error message is: boost/detail/sp_typeinfo.hpp(77) : error C2440: 'Initialisierung': 'const char *' kann nicht in 'boost::detail::sp_typeinfo' konvertiert werden (in english: 'const char *' cannot be converted to 'boost::detail::sp_typeinfo')

Before the change the line in sp_typeinfo.hpp(77) was:

template<class T> sp_typeinfo sp_typeid< T >::ti_( sp_typeid< T >::name() );

so, the explicit-marked ctor was called. Afterwards it changed to

template<class T> sp_typeinfo sp_typeid< T >::ti_ = sp_typeid< T >::name();

so the with "explicit" marked ctor of sp_typeid< T > can't be called anymore.

I suggest protecting the change with some compiler/platform-detection macro for the Sun Studio

Tobias

nstewart@… — Tue, 31 Aug 2010 15:50:47 GMT

The appropriate check for the SunPro compiler would be: SUNPRO_CC But I suspect that SunPro is right, and MSVC is wrong. :-)

Nigel

nstewart@… — Tue, 31 Aug 2010 15:51:58 GMT

Oops, make that

__SUNPRO_CC

status changed; resolution set

Peter Dimov — Fri, 24 Dec 2010 02:47:10 GMT

status reopened → closed
resolution → fixed

This was fixed with [66031], [66091], [66166].