owner, component changed

Steven Watanabe — Sat, 15 May 2010 02:19:51 GMT

owner changed from Vladimir Prus to Anthony Williams
component build → thread

cc set

feiyunw@… — Mon, 24 May 2010 13:54:43 GMT

cc feiyunw@… added

I got compile-time warnings with ogre-1.7.1 and boost-1.43.0 thread:

[  0%] Building CXX object OgreMain/CMakeFiles/OgreMain.dir/src/OgreAlignedAllocator.cpp.obj
cd OgreMain && C:\MinGW\bin\g++.exe   -DOgreMain_EXPORTS -D_WIN32_WINNT=0x0500 -DBOOST_ALL_NO_LIB -DOGRE_NONCLIENT_BUILD -DFREEIMAGE_LIB -D_MT -D_USRDLL -O3 -DNDEBUG -ID:\prj\ogre\ogre-1.7\OgreMain\include -I..\include -ID:\prj\ogre\ogre-1.7\Dependencies\include -ID:\prj\ogre\ogre-1.7\Dependencies\include\OIS -ID:\prj\ogre\ogre-1.7\Dependencies\include\Cg -IC:\PROGRA~1\MI21AE~1\Include -IC:\boost\include\boost-1_43 -ID:\prj\ogre\ogre-1.7\OgreMain\include\WIN32 -ID:\prj\ogre\ogre-1.7\OgreMain\src\nedmalloc   -msse -o CMakeFiles\OgreMain.dir\src\OgreAlignedAllocator.cpp.obj -c D:\prj\ogre\ogre-1.7\OgreMain\src\OgreAlignedAllocator.cpp
In file included from C:\boost\include\boost-1_43/boost/thread/win32/thread_heap_alloc.hpp:8:0,
                 from C:\boost\include\boost-1_43/boost/thread/detail/thread_heap_alloc.hpp:15,
                 from C:\boost\include\boost-1_43/boost/thread/tss.hpp:10,
                 from D:\prj\ogre\ogre-1.7\OgreMain\include/Threading/OgreThreadHeadersBoost.h:29,
                 from D:\prj\ogre\ogre-1.7\OgreMain\include/Threading/OgreThreadHeaders.h:30,
                 from D:\prj\ogre\ogre-1.7\OgreMain\include/OgreStdHeaders.h:110,
                 from D:\prj\ogre\ogre-1.7\OgreMain\include/OgrePrerequisites.h:315,
                 from D:\prj\ogre\ogre-1.7\OgreMain\src\OgreAlignedAllocator.cpp:30:
C:\boost\include\boost-1_43/boost/thread/win32/thread_primitives.hpp:123:73: warning: declaration of 'void boost::detail::win32::Sleep(long unsigned int)' with C language linkage
C:\boost\include\boost-1_43/boost/smart_ptr/detail/yield_k.hpp:58:29: warning: conflicts with previous declaration 'void boost::detail::Sleep(unsigned int)'

My environment is Windows XP (Chinese version, 32bit)/MinGW/g++-4.5.0. The reason is that Sleep() parameter type mismatches. In boost/thread/win32/thread_primitives.hpp:

namespace boost
{
    namespace detail
    {
        namespace win32
        { ...
            extern "C"
            { ...
                __declspec(dllimport) void __stdcall Sleep(unsigned long);

while in boost/smart_ptr/detail/yield_k.hpp:

namespace boost
{
namespace detail
{
#if !defined( BOOST_USE_WINDOWS_H )
  extern "C" void __stdcall Sleep( unsigned ms );
#endif

It looks like "extern C" modifier will make the function ignore namespace declaration. This makes sense as the function is defined in another module where we can't export namespace constraints. We should correct the parameter type to stop the compiler warnings.

owner, status, component changed

Peter Dimov — Wed, 26 May 2010 13:59:15 GMT

owner changed from Anthony Williams to Peter Dimov
status new → assigned
component thread → smart_ptr

'unsigned long' is correct according to <wtypes.h>, reassigning to myself.

Peter Dimov — Wed, 26 May 2010 17:49:39 GMT

(In [62246]) DWORD is unsigned long, not unsigned int. Refs #4217.

status changed; resolution set

Peter Dimov — Sat, 10 Jul 2010 21:07:16 GMT

status assigned → closed
resolution → fixed

(In [63826]) Merge [62246] to release. Fixes #4217.

Hesh — Mon, 11 Jun 2012 09:00:57 GMT

Hello,

I am using Ubuntu, codeBlocks, , boost 1.46 in GCC 4.7 [ yield_k.hpp ] I get this error ' error : Sleep was not declared in this scope' tried #include <unistd.h> and Sleep to sleep, nothing worked. when I change it to sleep 'error:expected initializer before 'sleep how Do I resolve this issue ??

Boost C++ Libraries: Ticket #4217: On Mingw-w64-i386 windows 7 plus gcc 4.5.0 gcc version 4.5.0 20100303 (experimental) (GCC) compiling error.

owner, component changed

cc set

owner, status, component changed

status changed; resolution set