Boost C++ Libraries: Ticket #4256: boost::make_shared() may issue stack overflow while constructing large objects

Peter Dimov — Thu, 24 Feb 2011 21:51:25 GMT

(In [69250]) Fix make_shared to not copy the deleter. Refs #4256. Refs #3875.

status changed

Peter Dimov — Thu, 24 Feb 2011 21:54:24 GMT

Peter Dimov — Tue, 22 Mar 2011 23:38:15 GMT

(In [70436]) Merge [69250] to release. Fixes #4256. Fixes #3875.

cameron.k.ward@… — Mon, 07 Nov 2011 17:42:38 GMT

I ran into this using 1.47 yesterday

I was in debug mode VS2010. I needed a pretty large receive buffer for a TCPReceiver.

The first enum caused a stack overflow error. Reducing the size stopped the error.

Release mode did not complain about either size.

struct TCPRawData{

void* pParent;

this blew the stack - enum{max_length = 1048576};

this was fine - enum{max_length = 500000};

char buffer[max_length];

int bytesReceived;

TCPRawData(void* parent): pParent(parent){}

};

cameron.k.ward@… — Mon, 07 Nov 2011 17:44:38 GMT

This was the offending code from the TCPReceiver.

TCPReadBuff = boost::make_shared<TCPRawData>(this);

szakharchenko@… — Thu, 28 Feb 2013 06:30:24 GMT

This is not fixed, at least in Boost 1.50. It's reproducible in VS2008 Debug build. Please reopen.

Peter Dimov — Thu, 28 Feb 2013 07:01:37 GMT

The above example (with A_Size = 512) works for me with the latest Boost and VS2005 Debug.

Peter Dimov — Thu, 28 Feb 2013 07:32:40 GMT

It does fail with A_Size=1024 though, which is probably what you mean.

Peter Dimov — Thu, 28 Feb 2013 08:02:13 GMT

(In [83198]) Avoid stack overflow in make_shared. Refs #4256.

Peter Dimov — Thu, 07 Mar 2013 08:18:51 GMT

(In [83341]) Merged revision(s) 83198 from trunk: Avoid stack overflow in make_shared. Fixes #4256. Fixes #7965.

anonymous — Tue, 22 Apr 2014 14:52:54 GMT

Not fixed in boost 1.55 either

Peter Dimov — Tue, 22 Apr 2014 15:15:29 GMT

Can you please tell me how to reproduce?