Boost C++ Libraries: Ticket #4297: [PATCH] Fix for warning: enumeral and non-enumeral type in conditional expression

attachment set

Fri, 04 Jun 2010 19:01:12 GMT

attachment → boost_interprocess_2.patch

Patch fixing the warnings: enumeral and non-enumeral type in conditional expression

status, milestone changed; resolution set

Ion Gaztañaga — Thu, 26 Aug 2010 10:46:29 GMT

status new → closed
resolution → fixed
milestone Boost 1.44.0 → Boost-1.45.0

Fixed for Boost 1.45 in release branch

visionofarun@… — Tue, 01 Feb 2011 17:01:14 GMT

Hi,

I'm reopening the ticket. This ticket appears in Boost 1.45.0 release notes. But seems like its not fixed yet. There are still warning messages with "g++ -W".

#include <boost/interprocess/managed_shared_memory.hpp>
int main()
{
   boost::interprocess::managed_shared_memory *mem;
   return 0;
}

g++ -c -W -fvisibility=hidden -g -Wall  1.cpp -o 1 -I/usr/local/include/boost-1.45.0/
In file included from /usr/local/include/boost-1.45.0/boost/interprocess/detail/managed_memory_impl.hpp:22,
                 from /usr/local/include/boost-1.45.0/boost/interprocess/managed_shared_memory.hpp:21,
                 from 1.cpp:1:
/usr/local/include/boost-1.45.0/boost/interprocess/mem_algo/rbtree_best_fit.hpp:321: warning: enumeral and non-enumeral type in conditional expression
1.cpp: In function 'int main()':
1.cpp:5: warning: unused variable 'mem'

status, version changed; cc, keywords set; resolution deleted

visionofarun@… — Tue, 01 Feb 2011 17:05:35 GMT

cc visionofarun@… added
keywords interprocess added
status closed → reopened
resolution fixed
version Boost Development Trunk → Boost 1.45.0

Hi,

Sorry for posting above.

I'm reopening the ticket. This ticket appears in Boost 1.45.0 release notes. But seems like its not fixed yet. There are still warning messages with "g++ -W".

#include <boost/interprocess/managed_shared_memory.hpp>
int main()
{
   boost::interprocess::managed_shared_memory *mem;
   return 0;
}

g++ -c -W -fvisibility=hidden -g -Wall  1.cpp -o 1 -I/usr/local/include/boost-1.45.0/
In file included from /usr/local/include/boost-1.45.0/boost/interprocess/detail/managed_memory_impl.hpp:22,
                 from /usr/local/include/boost-1.45.0/boost/interprocess/managed_shared_memory.hpp:21,
                 from 1.cpp:1:
/usr/local/include/boost-1.45.0/boost/interprocess/mem_algo/rbtree_best_fit.hpp:321: warning: enumeral and non-enumeral type in conditional expression
1.cpp: In function 'int main()':
1.cpp:5: warning: unused variable 'mem'

attachment set

Marshall Clow — Tue, 01 Feb 2011 17:40:39 GMT

attachment → mtc-4297.patch

Marshall Clow — Tue, 01 Feb 2011 17:41:03 GMT

Here's a patch that silences this warning.

status changed; resolution set

Ion Gaztañaga — Fri, 01 Apr 2011 18:52:20 GMT

status reopened → closed
resolution → fixed

Fixed in Boost 1.47

anonymous — Mon, 18 Jul 2011 13:07:23 GMT

i have installed Boost 1.47 right in this moment and it seems like this warning is still persistent...

Wed, 12 Oct 2011 10:05:40 GMT

Indeed, I confirm that the warning is still present with Boost 1.47.

The clean way to fix it is definitely to replace all the enums in metafunctions by the usage of BOOST_STATIC_CONSTANT as recommended in the Coding Guidelines for Integral Constant Expressions page and as I proposed in boost_interprocess_2.patch.

But as far as I can see, my patch has still not been applied in Boost 1.47.

Ex: type_traits.hpp of Boost 1.47

There are still enums whereas I replaced them by BOOST_STATIC_CONSTANT in boost_interprocess_2.patch.

status, milestone changed; resolution deleted

Wed, 12 Oct 2011 12:21:21 GMT

status closed → reopened
resolution fixed
milestone Boost 1.45.0 → Boost 1.48.0

As mentioned above, the warning is still present. The provided patch has not been applied.

anonymous — Sat, 03 Dec 2011 13:30:55 GMT

this is an incredibly, massively annoying bug.

status changed; resolution set

Ion Gaztañaga — Sat, 24 Dec 2011 11:00:46 GMT

status reopened → closed
resolution → fixed

Fixed in trunk, replaced all enum uses with static const values.