Boost C++ Libraries: Ticket #4327: warning C4244: conversion from '__int64' to 'long', possible loss of data

viboes — Wed, 09 Jun 2010 19:05:35 GMT

In addition the function interruptible_wait needs to be refactored when the number of milliseconds can not be hold on an unsigned long.

cc set

viboes — Wed, 09 Jun 2010 20:35:00 GMT

cc viboes added

James_E_K@… — Thu, 26 Aug 2010 13:32:36 GMT

I got rid of the warning by adding this after the existing pin_to_zero:

inline int64_t pin_to_zero(int64_t value) {

return (value<0)?0ull:(int64_t)value;

}

And adding this new interruptable_wait function:

inline void interruptible_wait(int64_t milliseconds) {

interruptible_wait(detail::win32::invalid_handle_value,milliseconds);

}

Whether or not this properly works with a value greater than ULONG_MAX is unknown.

sshock — Thu, 04 Nov 2010 21:17:19 GMT

I'm running into this too. How can I find out when it will be fixed?

Tue, 30 Nov 2010 18:31:44 GMT

The fix James_E_K suggested worked for me too....suggest something like this is rolled in as not many teams put up with that kind of warning from their code!

JFC — Tue, 21 Dec 2010 22:28:08 GMT

I also have this problem with VS2010 and Boost 1.45

wsxedcrfv — Wed, 22 Dec 2010 23:52:15 GMT

ok nice fix. but i get this error when i compile: LINK : fatal error LNK1561: Einstiegspunkt muss definiert werden.

i put the first function in thread_data.hpp at the and of the namespace detail and the second function at the end of the namespace this_thread.

im using visual c++ 2010 express and boost 1.45.

what have i done wrong?

anonymous — Wed, 23 Feb 2011 14:51:54 GMT

Is it fixed in 1.46?

anonymous — Thu, 10 Mar 2011 00:37:12 GMT

Can anyone tell me the best way to work around the issue for a simple call:

boost::this_thread::sleep(boost::posix_time::milliseconds(i_Milliseconds));

fails this way:

... : see reference to function template instantiation 'void boost::this_thread::sleep<boost::date_time::subsecond_duration<base_duration, frac_of_second>>(const TimeDuration &)' being compiled 1> with 1> [ 1> base_duration=boost::posix_time::time_duration, 1> frac_of_second=0x03e8, 1> TimeDuration=boost::date_time::subsecond_duration<boost::posix_time::time_duration,0x03e8> 1> ] ... thread_data.hpp(172): warning C4244: 'argument' : conversion from 'int64' to 'long', possible loss of data

Thanks!

anonymous — Thu, 10 Mar 2011 15:41:11 GMT

Replying to anonymous:

Is it fixed in 1.46?

Thu, 10 Mar 2011 17:47:43 GMT

While it will be fixed, here is workaround: convert to absolute time.

Example (boost 1.46):

void sleepMillisec( long milliseconds )
{
    boost::this_thread::sleep(
        boost::get_system_time() +
        boost::posix_time::milliseconds( std::max<long>(milliseconds,0) ) );
}

anonymous — Sun, 08 May 2011 00:30:24 GMT

Why hasn't this been fixed yet (as of 1.46.1)? I've had to use the edit James_E_K suggested above since this warning started appearing. It breaks all of my boost::this_thread::sleep code since I treat warnings as errors.

anonymous — Mon, 30 May 2011 16:50:21 GMT

when this will be fixed?

status changed; resolution set

Anthony Williams — Tue, 31 May 2011 12:29:15 GMT

status new → closed
resolution → fixed

Fixed on trunk, revision 72303