Boost C++ Libraries: Ticket #4353: warning needs suppressed --> warning: "_MSC_VER" is not defined

component changed; owner set

Steven Watanabe — Wed, 16 Jun 2010 22:22:11 GMT

owner set to Neil Groves
component None → range

attachment set

mdorey@… — Sun, 20 Jun 2010 20:01:02 GMT

attachment → D51645.patch

fix in the style of the earlier test in this file

mdorey@… — Sun, 20 Jun 2010 20:09:48 GMT

It's perhaps stating the obvious, but nonetheless worth doing so for the benefit of search engines, that this warning occurs with gcc when passed the -Wundef flag. (This little-known and rarely-used flag is useful because it stops you from doing #if tests when the appropriate header file hasn't been included.) Much of boost is clean in the presence of this flag and I've had other similar patches accepted in the past. Another technique that's sometimes used to fix this sort of issue is BOOST_WORKAROUND, as demonstrated in eg https://svn.boost.org/trac/boost/ticket/1291. I didn't choose that approach because I'm less familiar with it and I was concerned for consistency with the existing defined(_MSC_VER) test higher up this file.

status changed; resolution set

Neil Groves — Sat, 17 Jul 2010 19:55:00 GMT

status new → closed
resolution → fixed