Boost C++ Libraries: Ticket #4355: without namespace 'range_detail'

attachment set

rick68@… — Wed, 16 Jun 2010 23:17:48 GMT

attachment → concepts.hpp.diff

without namespace 'range_detail'

severity changed

Steven Watanabe — Thu, 24 Jun 2010 20:09:08 GMT

severity Problem → Cosmetic

The code works correctly without this patch, because Boost.ConceptCheck includes these concepts in the boost namespace. What I'd like to know is why range defines its own versions of the iterator concepts, instead of using the ones from Boost.ConceptCheck?

rick68@… — Sun, 27 Jun 2010 16:35:52 GMT

Replying to steven_watanabe:

The code works correctly without this patch, because Boost.ConceptCheck includes these concepts in the boost namespace. What I'd like to know is why range defines its own versions of the iterator concepts, instead of using the ones from Boost.ConceptCheck?

In Boost.ConceptCheck are 'BidirectionalIterator' and 'RandomAccessIterator', I can't find 'BidirectionalIteratorConcept' and 'RandomAccessIteratorConcept'.

Steven Watanabe — Sun, 27 Jun 2010 18:37:44 GMT

If you trace through the macros, you'll find that they define versions both with and without the Concept suffix.

attachment set

rick68@… — Sun, 27 Jun 2010 19:33:46 GMT

attachment → test.cpp

test BidirectionalRangeConcept

rick68@… — Sun, 27 Jun 2010 19:45:21 GMT

Replying to steven_watanabe:

If you trace through the macros, you'll find that they define versions both with and without the Concept suffix.

I attach 'test.cpp', maybe you can test it :)

Steven Watanabe — Mon, 28 Jun 2010 02:06:28 GMT

with the trunk I get

C:\boost\trunk\boost/concept_check.hpp(516) : error C2100: illegal indirection
        C:\boost\trunk\boost/concept_check.hpp(510) : while compiling class template member function 'boost::ForwardIterator<TT>::~ForwardIterator(void)'
        with
        [
            TT=Iterator<ValueType>
        ]

which is the expected result, as there's no operator*.

rick68@… — Mon, 28 Jun 2010 03:23:27 GMT

Replying to steven_watanabe:

with the trunk I get

C:\boost\trunk\boost/concept_check.hpp(516) : error C2100: illegal indirection
        C:\boost\trunk\boost/concept_check.hpp(510) : while compiling class template member function 'boost::ForwardIterator<TT>::~ForwardIterator(void)'
        with
        [
            TT=Iterator<ValueType>
        ]

which is the expected result, as there's no operator*.

BidirectionalIteratorConcept check concept with ForwardIteratorConcept, DefaultConstructiable, SignlePassIterator, IncrementableIteratorConcept, EqualityComparable and CopyConstructiable, they are not to check operator*. But if I add 'detail_range::' in concepts.hpp at line 298, 299, the compiler can complete this code.

Steven Watanabe — Mon, 28 Jun 2010 04:30:16 GMT

Oh. I see that range_detail::ForwardIteratorConcept doesn't check for operator*. This is a bug. operator* is required for ForwardIterators. test.cpp should not compile.

status changed

Neil Groves — Sun, 14 Nov 2010 17:46:51 GMT

status new → assigned

status, milestone changed; resolution set

Neil Groves — Thu, 23 Dec 2010 12:15:12 GMT

status assigned → closed
resolution → fixed
milestone Boost 1.43.0 → Boost 1.46.0

Resolved on the trunk.