Boost C++ Libraries: Ticket #4475: OpenVMS patch for 64 bit support

attachment set

artyomtnk@… — Tue, 27 Jul 2010 14:10:29 GMT

attachment → date_time.patch

Rob Stewart — Thu, 13 Jan 2011 13:09:48 GMT

You propose the following structure:

#if defined(__VMS) && __INITIAL_POINTER_SIZE == 64
   std::tm tmp;
   if(!localtime_r(t,&tmp))
      result = 0;
   else
      *result = tmp;
#else
   result = localtime_r(t, result);
#endif

Why not this instead? That is, why is tmp needed?

#if defined(__VMS) && __INITIAL_POINTER_SIZE == 64
   if (!localtime_r(t, result))
      result = 0;
#else
   result = localtime_r(t, result);
#endif

artyomtnk@… — Thu, 13 Jan 2011 13:33:37 GMT

The problem is that VMS allows mixed 32 and 64 bit pointers (something like DOS's near/far) and some system functions - in this case localetime_r, accept only 32 bit pointers while most accept both type of pointer.

What happens is that I need to pass 32 bit pointer to the function to make sure it works. Result is 64 bit pointer so I can't pass it as is. So I create a local variable tmp that is placed on stack. And it is promised that stack is always placed in 32bit region so I can relate on the fact that the pointer would be 32bit pointer.

And after I get the result I can copy it to the location of 64 bit pointer.

This is quite ugly but that is how OpenVMS works.

Thanks,

Artyom

Marshall Clow — Wed, 30 Mar 2011 22:25:28 GMT

(In [70767]) Applied patch - Refs #4475

status changed; resolution set

Marshall Clow — Mon, 04 Apr 2011 23:33:56 GMT

status new → closed
resolution → fixed

(In [70982]) Merge date/time fixes to release. Fixes #4475