Boost C++ Libraries: Ticket #4657: Boost.MPI Compile failure with Python 3

attachment set

anonymous — Sat, 18 Sep 2010 18:05:18 GMT

attachment → boost-1.44-py3.1.patch

Matthias Troyer — Wed, 03 Nov 2010 19:36:37 GMT

What are the license conditions for the part inserted as " Code stolen from py3k/Modules/python.c."?

owner, status changed

Matthias Troyer — Wed, 03 Nov 2010 19:36:53 GMT

owner changed from Douglas Gregor to Matthias Troyer
status new → assigned

inform@… — Thu, 04 Nov 2010 02:30:28 GMT

http://docs.python.org/py3k/license.html#terms-and-conditions-for-accessing-or-otherwise-using-python

Andreas

anonymous — Thu, 04 Nov 2010 07:09:07 GMT

Thanks! The only issue I see here is that they require that "PSF’s License Agreement " is retained, while we want to publish it under the Boost license. Do you know the authors of that piece of code so that we can ask them whether we can use it here? Otherwise we'll have to reimplement a similar idea but can't just copy&paste.

inform@… — Thu, 04 Nov 2010 17:46:01 GMT

Well, I think we can consider the patch a reimplementation, since I had to change their UCS handling functions to codecvt. I don't think it's likely that the Python guys will come suing us over this.

Andreas

anonymous — Thu, 04 Nov 2010 20:54:12 GMT

Thanks for the clarification.

Mon, 09 May 2011 00:07:08 GMT

This problem still exists in 1.46.1. Is there any chance of getting this patch pushed through into trunk?

anonymous — Sun, 04 Dec 2011 05:58:23 GMT

This problem still exists in 1.48.0

anonymous — Tue, 03 Jan 2012 17:28:42 GMT

Can you test whether the trunk works for you?

smr@… — Wed, 04 Jan 2012 03:03:36 GMT

I can confirm the trunk now works: I built against python 3.2. Thanks, -Steve

smr@… — Wed, 01 Feb 2012 03:59:18 GMT

Can this be pushed to release, please?

anonymous — Sun, 05 Feb 2012 10:54:15 GMT

The attached patch (as well as r76290) seems to introduce memory leak in argv conversion code. When you return false from the loop in bool mpi_init(list python_argv, bool abort_on_exception), memory allocated for argv_copy and argv_copy2 is not freed.

Also, the following code returns 1 in case of error, which is converted to true (because function is returning boolean):

if (myresult != std::codecvt<wchar_t,char,mbstate_t>::ok )
{
    fprintf(stderr, "failure translating argv\n");
    return 1;
}

cc set

Sun, 05 Feb 2012 10:54:46 GMT

cc iv@… added

anonymous — Tue, 03 Dec 2013 09:18:26 GMT

Still broken in 1.54 with Python 3.3.3.