Boost C++ Libraries: Ticket #4715: custom property_map no longer works for astar_search

component changed; owner set

Tue, 05 Oct 2010 23:49:45 GMT

owner set to Andrew Sutton
component None → graph

owner changed

Jeremiah Willcock — Wed, 06 Oct 2010 00:29:45 GMT

owner changed from Andrew Sutton to Jeremiah Willcock

Jeremiah Willcock — Wed, 06 Oct 2010 00:30:17 GMT

Could you please attach the full instantiation stack and/or a complete piece of code to test?

attachment set

Wed, 06 Oct 2010 08:00:53 GMT

attachment → main.cpp

Wed, 06 Oct 2010 08:02:12 GMT

Extracted code for test. Also, I forgot to mention that I am building with Visual Studio 2008 SP1.

status changed; resolution set

Jeremiah Willcock — Wed, 06 Oct 2010 19:53:22 GMT

status new → closed
resolution → worksforme

In my testing, you just need an extra include:

#include <boost/utility/result_of.hpp>

and then it compiles fine with GCC 4.1.2 and the Boost trunk.

Wed, 06 Oct 2010 21:05:58 GMT

This does not work for me and in fact original code had that file included.

Even replacing

namespace boost {
  template <typename Functor, typename Arg>
  struct property_traits<function_property_map<Functor, Arg> > {
    typedef typename boost::result_of<Functor(Arg)>::type value_type;
    typedef value_type reference;
    typedef Arg key_type;
    typedef boost::readable_property_map_tag category;
  };
}

with

namespace boost {
  template <typename Functor, typename Arg>
  struct property_traits<function_property_map<Functor, Arg> > {
    typedef int value_type;
    typedef value_type reference;
    typedef Arg key_type;
    typedef boost::readable_property_map_tag category;
  };
}

results with same error

Jeremiah Willcock — Wed, 06 Oct 2010 21:09:04 GMT

What needs to be changed is the typedef for value_type in function_property_map. It should be

typedef typename boost::result_of<Functor(Arg)>::type
  value_type;

to avoid a potentially circular definition.

Wed, 06 Oct 2010 21:41:18 GMT

Still same error, even with both value_type typedefs (in function_property_map and property_traits) hardcoded to int.

I found that last working revision is 63530.

Briefly judging by revision's description, do I miss some const definitions?

Jeremiah Willcock — Wed, 06 Oct 2010 23:15:05 GMT

Could you please post the entire error message (including the full instantiation stack)?

attachment set

Wed, 06 Oct 2010 23:42:40 GMT

attachment → BuildLog.htm

Wed, 06 Oct 2010 23:44:08 GMT

VS build log attached

Jeremiah Willcock — Wed, 06 Oct 2010 23:57:37 GMT

Could you please try this patch:

Index: /u/jewillco/boost-svn/boost/graph/astar_search.hpp
===================================================================
--- /u/jewillco/boost-svn/boost/graph/astar_search.hpp  (revision 65774)
+++ /u/jewillco/boost-svn/boost/graph/astar_search.hpp  (working copy)
@@ -318,11 +318,11 @@
     // otherwise the value type of the weight map.
     typedef
       typename detail::override_const_property_result<
-                 arg_pack_type, tag::weight_map, edge_weight_t, VertexListGraph>::type
+                 arg_pack_type, tag::weight_map, edge_weight_t, const VertexListGraph>::type
       weight_map_type;
     typedef typename boost::property_traits<weight_map_type>::value_type W;
     typedef
-      typename detail::map_maker<VertexListGraph, arg_pack_type, tag::distance_map, W>::map_type
+      typename detail::map_maker<const VertexListGraph, arg_pack_type, tag::distance_map, W>::map_type
       distance_map_type;
     typedef typename boost::property_traits<distance_map_type>::value_type D;
@@ -355,7 +355,7 @@
     BOOST_GRAPH_DECLARE_CONVERTED_PARAMETERS(params_type, params)
     typedef
       typename detail::override_const_property_result<
-                 arg_pack_type, tag::weight_map, edge_weight_t, VertexListGraph>::type
+                 arg_pack_type, tag::weight_map, edge_weight_t, const VertexListGraph>::type
                weight_map_type;
     typedef typename boost::property_traits<weight_map_type>::value_type D;
     astar_search_no_init

Thu, 07 Oct 2010 00:41:32 GMT

No luck.

anonymous — Thu, 07 Oct 2010 21:17:39 GMT

Any other way I could help?

Jeremiah Willcock — Thu, 07 Oct 2010 22:33:33 GMT

See if this patch works (either with or without the one I sent before):

Index: boost/graph/named_function_params.hpp
===================================================================
--- boost/graph/named_function_params.hpp       (revision 65774)
+++ boost/graph/named_function_params.hpp       (working copy)
@@ -392,8 +392,8 @@
     template <typename ArgType, typename Prop, typename Graph, bool Exists>
     struct override_const_property_t {
-      typedef ArgType result_type;
-      result_type operator()(const Graph&, const typename boost::add_reference<ArgType>::type a) const {return a;}
+      typedef typename boost::remove_const<ArgType>::type result_type;
+      result_type operator()(const Graph&, const ArgType& a) const {return a;}
     };
     template <typename ArgType, typename Prop, typename Graph>

anonymous — Fri, 08 Oct 2010 17:31:33 GMT

That works even without first patch applied. Thanks.

resolution changed

Jeremiah Willcock — Fri, 08 Oct 2010 17:33:23 GMT

resolution worksforme → fixed

(In [65836]) Fixed const issue on VC++ 8; fixes #4715

Jeremiah Willcock — Fri, 08 Oct 2010 18:07:13 GMT

(In [65839]) Merged r65836 (fix for #4715) from trunk; refs #4715