Boost C++ Libraries: Ticket #4752: subgraph::remove_vertex is not implemented

owner, status changed

Jeremiah Willcock — Tue, 19 Oct 2010 15:53:42 GMT

owner changed from Andrew Sutton to Jeremiah Willcock
status new → assigned

Jeremiah Willcock — Tue, 19 Oct 2010 15:55:32 GMT

(In [66098]) Fixed remove_edge_if and clear_vertex for subgraphs; commented out remove_vertex; refs #4752; fixes #4753

Jeremiah Willcock — Tue, 19 Oct 2010 16:13:56 GMT

(In [66100]) Merged r66097, r66098, and r66099 from trunk; refs #4758, #4752, #4753, #4631

status changed; resolution set

Jeremiah Willcock — Tue, 26 Oct 2010 18:28:42 GMT

status assigned → closed
resolution → wontfix

I'm going to mark this as wontfix for now; please reopen it if you think it is important to fix.

status changed; resolution deleted

Wed, 27 Oct 2010 21:30:48 GMT

status closed → reopened
resolution wontfix

I think this should be reopened. Remove_vertex is a common operation, and if left unimplemented, subgraphs are immutable. Actually, not totally immutable because edges can be removed, but then why implement remove_edge and leave out remove_vertex?

status changed; resolution set

Jeremiah Willcock — Sat, 30 Oct 2010 21:19:50 GMT

status reopened → closed
resolution → wontfix

I looked through to code to see what it would take to add remove_vertex, and it would be basically impossible to do. In particular, local vertex descriptors in subgraphs are indices into an std::vector, and so removing a vertex would invalidate many other vertex descriptors. If it is necessary to remove a vertex from a subgraph, it might be better to wrap the subgraph with a filtered_graph with a property map to hide the "removed" vertices. Using filtered_graph would often be better than subgraph for simple use cases, even without vertex removal.