Boost C++ Libraries: Ticket #4793: copy_component does not work for graphs with edges.

attachment set

Tue, 26 Oct 2010 17:45:02 GMT

attachment → copy_component_kaput.cpp

Simple test.

Tue, 26 Oct 2010 17:47:53 GMT

One possibly fix would be to have tree_edge(e,g) create a vertex for target(e,g) and the edge for e, and have non_tree_edge(e,g) create an edge for e using the already existing target(e,g).

owner, status changed

Jeremiah Willcock — Tue, 26 Oct 2010 17:59:21 GMT

owner changed from Andrew Sutton to Jeremiah Willcock
status new → assigned

Jeremiah Willcock — Tue, 26 Oct 2010 18:11:30 GMT

With the method you suggested, you only need to specifically copy the source vertex since every other vertex in the component is the target of some tree or non-tree edge. Thus, your approach actually simplifies the code further by removing the examine_vertex hook. I am working on fixing this bug the way you suggested.

Tue, 26 Oct 2010 18:18:09 GMT

Great! Thank you for the incredibly rapid response.

status changed; resolution set

Jeremiah Willcock — Tue, 26 Oct 2010 18:24:03 GMT

status assigned → closed
resolution → fixed

(In [66203]) Repaired copy_component() using suggestion from Christopher Alfeld; fixes #4793

Jeremiah Willcock — Tue, 26 Oct 2010 18:25:57 GMT

Could you please try your code again with the version I just committed to the trunk? Please try valgrind on it as well if you have a platform that supports it.

Tue, 26 Oct 2010 18:32:32 GMT

Code does not compile. On line 404, you call copy_one_vertex with a single argument, when it takes two.

After fixing that error (adding g_in as the second argument) code runs correctly and valgrind reports no errors.

Jeremiah Willcock — Tue, 26 Oct 2010 18:37:35 GMT

(In [66204]) Fixed signature of copy_one_vertex(); refs #4793

Jeremiah Willcock — Tue, 26 Oct 2010 20:37:40 GMT

(In [66206]) Merged r66203 and r66204 from trunk; refs #4793