Boost C++ Libraries: Ticket #4849: MinGW-64: detail/interlocked.hpp chooses wrong prototypes for InterlockedCompareExchange et al

Peter Dimov — Sat, 13 Nov 2010 12:18:31 GMT

BOOST_USE_WINDOWS_H is a user macro; it causes boost headers to include <windows.h>, which should never happen automatically.

cc changed

Wed, 01 Dec 2010 11:36:19 GMT

cc sam@… added

Peter Dimov — Wed, 01 Dec 2010 14:33:42 GMT

I see that the "Win7-x64 jc-bell.com" regression tester doesn't have the issue, but this may be caused by a different version of windows.h. Either way, this is not (in my opinion) an issue with interlocked.hpp, it's caused by thread.cpp including windows.h before once.hpp. windows.h then (I assume) defines Interlocked* as macros to _Interlocked*. Putting the windows.h include last should solve the problem.

Wed, 01 Dec 2010 14:45:48 GMT

"Win7-x64 jc-bell.com" is my platform (still experimental), and it this works because I have a fix for it. It #undef's Interlocked... stuff after #include <windows.h>

attachment set

Wed, 01 Dec 2010 14:46:10 GMT

attachment → mingw64-thread.patch

Wed, 01 Dec 2010 14:48:01 GMT

To clarify: the patch applies to boost/libs/thread/src/win32/thread.cpp

Peter Dimov — Wed, 01 Dec 2010 15:01:20 GMT

Can you please try moving the <windows.h> include last instead?

anonymous — Wed, 01 Dec 2010 23:52:36 GMT

Yes. Moving #include <windows.h> below all other includes DOES correct the above "_Interlocked..." errors above.

I'm attaching a patch that shows this, and also a couple other related MinGW-64 patches that might be helpful. Review it carefully.

attachment set

Wed, 01 Dec 2010 23:54:35 GMT

attachment → mingw64-thread-2.patch

owner, component changed

Peter Dimov — Fri, 03 Dec 2010 00:05:08 GMT

owner changed from Peter Dimov to Anthony Williams
component smart_ptr → thread

I'll reassign this to Anthony for now, he can bounce it back to me later. :-)

anonymous — Sun, 20 Mar 2011 17:18:47 GMT

I'll just want to bump this since it wasn't fixed in the latest 1.46.1 release... if bumping is not usual in such bug-trackers I apologize for the inconvenience. ;)

anonymous — Mon, 21 Mar 2011 22:24:32 GMT

Same. I met the issue on my build today. What would be the next delivery in an official build ?

Mon, 21 Mar 2011 22:55:59 GMT

One problem is that boost doesn't have a reliable mingw64 regression test for trunk and release. Mine's experimental, trunk-only, and doesn't get run often (to say the least). So the maintainer probably isn't going to take a chance on it.

Anyone want to run trunk and release regressions until this change gets shepherded through trunk and release branches? If so, we can at least try to get the maintainer's attention: I'll send him a polite e-mail about it. (No guarantee it'll get fixed even then.)

Until then, look at the attached patches and patch your distribution. Hate to say it, but that's the expedient fix.

status changed

Anthony Williams — Mon, 21 Mar 2011 23:10:56 GMT

status new → assigned

I've applied the patch to trunk (revision 70383). If it doesn't cause any problems it can be merged to release.

anonymous — Tue, 22 Mar 2011 19:54:53 GMT

Thank you very much for your affords :)

cc changed

Fri, 17 Jun 2011 09:58:56 GMT

cc phprus@… added

Tell please, this patch will get into release 1.47.0?

mayburn11 — Tue, 21 Jun 2011 23:46:52 GMT

i lost few days on investigate why mingw64 chokes compiling my code then i saw this

i patched my boost release to it and it works well

it be very nice if it can be merged to release branch

thank you mayburn11

Wed, 22 Jun 2011 12:25:35 GMT

This will be released in boost 1.47.0. See http://lists.boost.org/Archives/boost/2011/06/182834.php.

status changed; resolution set

viboes — Wed, 07 Dec 2011 18:14:07 GMT

status assigned → closed
resolution → fixed

Closed as for the comments it seems this was committed in release branch.

mattyclarkson@… — Mon, 09 Sep 2013 09:05:17 GMT

Just hit this same issue building 1.54.0 with MinGW-builds-x64-4.8.1-posix-seh on Windows 7 x64:

C:\Users\Matt\Documents\git\tool-chain\third_party\source\http\boost_1_54_0>b2 t
oolset=gcc variant=release link=shared threading=multi runtime-link=shared --pre
fix=C:\boost-1.54.0 --with-thread -d+2
Building the Boost C++ Libraries.
Component configuration:
    - atomic                   : not building
    - chrono                   : not building
    - context                  : not building
    - coroutine                : not building
    - date_time                : not building
    - exception                : not building
    - filesystem               : not building
    - graph                    : not building
    - graph_parallel           : not building
    - iostreams                : not building
    - locale                   : not building
    - log                      : not building
    - math                     : not building
    - mpi                      : not building
    - program_options          : not building
    - python                   : not building
    - random                   : not building
    - regex                    : not building
    - serialization            : not building
    - signals                  : not building
    - system                   : not building
    - test                     : not building
    - thread                   : building
    - timer                    : not building
    - wave                     : not building
gcc.link.dll bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\li
bboost_thread-mgw48-mt-1_54.dll.a
    "g++"   "-Wl,--out-implib,bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\t
hreading-multi\libboost_thread-mgw48-mt-1_54.dll.a" -o "bin.v2\libs\thread\build
\gcc-mingw-4.8.1\release\threading-multi\libboost_thread-mgw48-mt-1_54.dll"  -sh
ared -Wl,--start-group "bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threadi
ng-multi\win32\thread.o" "bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threa
ding-multi\win32\tss_dll.o" "bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\th
reading-multi\win32\tss_pe.o" "bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\
threading-multi\future.o" "bin.v2\libs\chrono\build\gcc-mingw-4.8.1\release\thre
ading-multi\libboost_chrono-mgw48-mt-1_54.dll.a" "bin.v2\libs\system\build\gcc-m
ingw-4.8.1\release\threading-multi\libboost_system-mgw48-mt-1_54.dll.a"  -Wl,-Bs
tatic  -Wl,-Bdynamic  -Wl,--end-group -mthreads
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x387): undefined reference to `InterlockedCompareExchange'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x3a4): undefined reference to `InterlockedCompareExchange'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x400): undefined reference to `InterlockedExchange'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x47e): undefined reference to `InterlockedIncrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x494): undefined reference to `InterlockedCompareExchange'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x781): undefined reference to `InterlockedIncrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x79c): undefined reference to `InterlockedCompareExchange'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x9a0): undefined reference to `InterlockedCompareExchange'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x9bd): undefined reference to `InterlockedCompareExchange'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0xa19): undefined reference to `InterlockedExchange'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0xa9f): undefined reference to `InterlockedIncrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0xab5): undefined reference to `InterlockedCompareExchange'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0xee2): undefined reference to `InterlockedIncrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0xefd): undefined reference to `InterlockedCompareExchange'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x1026): undefined reference to `InterlockedIncrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x10d9): undefined reference to `InterlockedIncrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x1159): undefined reference to `InterlockedDecrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x11e8): undefined reference to `InterlockedIncrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x1227): undefined reference to `InterlockedDecrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x1293): undefined reference to `InterlockedDecrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x1310): undefined reference to `InterlockedDecrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x13a9): undefined reference to `InterlockedDecrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x1445): undefined reference to `InterlockedDecrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x1a3d): undefined reference to `InterlockedCompareExchange'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x1a5a): undefined reference to `InterlockedCompareExchange'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x1ab6): undefined reference to `InterlockedExchange'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x1b21): undefined reference to `InterlockedIncrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x1b37): undefined reference to `InterlockedCompareExchange'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x1df1): undefined reference to `InterlockedIncrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x1e0c): undefined reference to `InterlockedCompareExchange'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x3212): undefined reference to `InterlockedDecrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x3328): undefined reference to `InterlockedDecrement'
bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\win32\thread.o:
thread.cpp:(.text+0x1130): undefined reference to `InterlockedIncrement'
c:/users/matt/documents/git/tool-chain/third_party/mingw-builds/4.8.1/x64/posix/
seh/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/4.8.1/../../../../x86_64-w64-mingw
32/bin/ld.exe: bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\
win32\thread.o: bad reloc address 0x8 in section `.data'
collect2.exe: error: ld returned 1 exit status
...removing bin.v2\libs\thread\build\gcc-mingw-4.8.1\release\threading-multi\lib
boost_thread-mgw48-mt-1_54.dll.a
...skipped <pstage\lib>libboost_thread-mgw48-mt-1_54.dll.a for lack of <pbin.v2\
libs\thread\build\gcc-mingw-4.8.1\release\threading-multi>libboost_thread-mgw48-
mt-1_54.dll.a...
...skipped <pstage\lib>libboost_thread-mgw48-mt-1_54.dll for lack of <pbin.v2\li
bs\thread\build\gcc-mingw-4.8.1\release\threading-multi>libboost_thread-mgw48-mt
-1_54.dll...
...failed updating 2 targets...

I'm trying to figure out why the macros are not set to the correct symbols, if anyone has any pointers for me, I welcome a hint :)

Mon, 09 Sep 2013 10:32:28 GMT

@mattyclarkson: Have you studied/applied the patches in this ticket?

Mon, 09 Sep 2013 14:07:36 GMT

@jim: I solved this by adding define=BOOST_USE_WINDOWS_H to fix the build. That forces the inclusion of windows.h pulling in the correct definitions for the symbols. I went over the patches, they all seem to be in the trunk now, so was a little lost but found some more information around on Google about building Boost with MinGW x64.

viboes — Mon, 09 Sep 2013 17:43:55 GMT

It seems that there is a regression on mingw 64

See http://sourceforge.net/mailarchive/message.php?msg_id=31189847.

bronf — Mon, 23 Sep 2013 10:23:13 GMT

I have eventually fixed this issue without having to define BOOST_USE_WINDOWS_H (which causes issues when compiling with wxWidgets for example). The patch (https://svn.boost.org/trac/boost/attachment/ticket/4849/interlocked.diff) works with mingw-w64 targeting both i686 and x86_64. Hope this can be included in 1.55.0.

attachment set

bronf — Mon, 23 Sep 2013 13:05:32 GMT

attachment → interlocked.diff

version, milestone changed

Wed, 02 Oct 2013 09:59:29 GMT

version Boost Development Trunk → Boost 1.54.0
milestone Boost 1.46.0 → Boost 1.55.0

Have the same problem and made a patch. It deals with mingw64 in its own #elif and undoes BOOST_INTERLOCKED_IMPORT from mingw64-thread-2.patch Tested with mingw64 4.8.1 64 and 32 bits and threads compile and work.

attachment set

Wed, 02 Oct 2013 10:00:29 GMT

attachment → mingw64_iterlocked.patch

Peter Dimov — Wed, 02 Oct 2013 10:28:48 GMT

This should have been fixed by revision [85865].