Boost C++ Libraries: Ticket #4891: include config/user.hpp in filesystem/* headers

status changed; resolution set

Beman Dawes — Sat, 04 Dec 2010 12:54:33 GMT

status new → closed
resolution → fixed

All Boost.Filesystem headers already first include <boost/config.hpp> directly or indirectly. That isn't obvious, particularly for V2, so I added some initial V2 includes to make it more obvious.

The documentation has also been changed to add <boost/config/user.hpp> to the list of places where BOOST_FILESYSTEM_VERSION can be defined.

Thanks,

--Beman

status changed; resolution deleted

Andrey Semashev — Sun, 05 Dec 2010 10:54:13 GMT

status closed → reopened
resolution fixed

No, it doesn't work, because headers directly beneath filesystem directory don't include config.hpp. Assuming I have #defined BOOST_FILESYSTEM_VERSION 2 in my user.hpp, compiling this code fails:

#include <boost/filesystem/path.hpp>
template< typename T1, typename T2 >
void with_path(boost::filesystem::basic_path< T1, T2 >)
{
}
int main(int, char*[])
{
    with_path(boost::filesystem::path());
    return 0;
}

The error is as follows:

In file included from ./boost/config.hpp:26,
                 from ./boost/filesystem/v3/path.hpp:18,
                 from ./boost/filesystem/path.hpp:28,
                 from fs_test.cpp:1:
./boost/config/user.hpp:123: warning: "BOOST_FILESYSTEM_VERSION" redefined
./boost/filesystem/path.hpp:21: note: this is the location of the previous definition
In file included from ./boost/filesystem/v3/path.hpp:24,
                 from ./boost/filesystem/path.hpp:28,
                 from fs_test.cpp:1:
./boost/filesystem/v3/config.hpp:16: error: #error Compiling Filesystem version 3 file with BOOST_FILESYSTEM_VERSION defined != 3
fs_test.cpp:4: error: variable or field ‘with_path’ declared void
fs_test.cpp:4: error: ‘basic_path’ is not a member of ‘boost::filesystem’
fs_test.cpp:4: error: expected primary-expression before ‘,’ token
fs_test.cpp:4: error: expected primary-expression before ‘>’ token
fs_test.cpp:4: error: expected primary-expression before ‘)’ token
fs_test.cpp: In function ‘int main(int, char**)’:
fs_test.cpp:11: error: ‘with_path’ was not declared in this scope

status changed; resolution set

Beman Dawes — Mon, 06 Dec 2010 13:17:48 GMT

status reopened → closed
resolution → fixed

(In [67066]) Fix #4891, again, clearing problem if BOOST_FILESYSTEM_VERSION defined in <boost/config/user.hpp>

attachment set

anonymous — Fri, 20 Jul 2012 08:39:07 GMT

attachment → config.hpp