Boost C++ Libraries: Ticket #4919: gil_concept.hpp triggers self-assignment warnings

attachment set

gromer@… — Wed, 01 Dec 2010 21:08:18 GMT

attachment → selfassign.patch

Partial fix for the bug

type changed

Tue, 07 Dec 2010 17:21:59 GMT

type Bugs → Patches

gromer@… — Tue, 14 Dec 2010 20:30:06 GMT

Please note that the attached patch does not completely resolve the issue; as noted in the summary I do not know what the correct resolution is for the self-assignment in PointNDConcept, because either the code is incorrect or the documentation is incomplete, and I don't know which.

Dean Michael Berris — Wed, 07 Nov 2012 03:53:16 GMT

Any updates on this? Can we remove the self-assignment check in the concept instead completely? There are other ways to test for assignable which doesn't involve self-assignment.

owner changed

Dean Michael Berris — Wed, 14 Nov 2012 10:59:27 GMT

owner changed from Hailin Jin to Marshall Clow

Replying to gromer@…:

Please note that the attached patch does not completely resolve the issue; as noted in the summary I do not know what the correct resolution is for the self-assignment in PointNDConcept, because either the code is incorrect or the documentation is incomplete, and I don't know which.

Okay, I had a look at this and it seems that PointNDConcept<T> does imply that it should be Regular<T>. This means it supports all the regular type requirements.

Because this is a concept check it means whatever is in the concept definition determines the requirements. I'm inclined to think that merely switching the assignment to:

value_type v = p[0];
p[0] = v;

Should fix the issue properly. I'll attach a new patch that should fix this.

Dean Michael Berris — Wed, 14 Nov 2012 11:24:11 GMT

Also, as an addendum, the concept does require that the type T has a subscript operator, as this deals with axes of a Point. Subsequent Point*DConcept tests that depend on PointNDConcept where subscripting is required. In my patch I have updated the concept documentation to reflect this.

attachment set

Dean Michael Berris — Mon, 19 Nov 2012 00:18:16 GMT

attachment → boost-gil-self-assignment-fix.patch

Updated documentation and self-assignments.

Dean Michael Berris — Mon, 19 Nov 2012 00:19:12 GMT

Apologies for the delay. Marshall, would you mind having a look at the updated patch?

Marshall Clow — Mon, 17 Dec 2012 18:00:53 GMT

I spoke to Lubomir, and he said:

"PointNDConcept is an N-dimensional point where each dimension may have a different type. Therefore it cannot have operator[]. So the documentation is correct and the line point[0] = point[0] should be removed."

attachment set

Marshall Clow — Tue, 18 Dec 2012 15:15:10 GMT

attachment → gil.patch

Revised GIL self-assignment patch

Dean Michael Berris — Wed, 19 Dec 2012 04:36:29 GMT

Okay, this looks and sounds good to me! Can we commit this change and perhaps get this to a release branch too? :)

Marshall Clow — Wed, 19 Dec 2012 05:09:08 GMT

(In [82092]) Apply patch for Lubomir; Refs #4919

Dean Michael Berris — Wed, 14 Aug 2013 02:53:14 GMT

Can we get an update on when [82092] will make it into a release? 1.54.0 still doesn't have this IIUC.

cc set

Mateusz Loskot — Thu, 16 Feb 2017 10:53:53 GMT

cc mateusz@… added

owner changed

Stefan Seefeld — Sat, 01 Jul 2017 21:13:12 GMT

owner changed from Marshall Clow to Stefan Seefeld

status, milestone changed; resolution set

Mateusz Loskot — Sat, 25 Aug 2018 15:53:09 GMT

status new → closed
resolution → fixed
milestone To Be Determined → Boost 1.68.0

The patch was released in GIL with Boost 1.68

https://github.com/boostorg/gil/blob/boost-1.67.0/include/boost/gil/gil_concept.hpp

https://github.com/boostorg/gil/blob/boost-1.68.0/include/boost/gil/gil_concept.hpp

github ref: https://github.com/boostorg/gil/projects/4#card-12439478