Boost C++ Libraries: Ticket #4987: pch.hpp.gch build fails with boost::swap' has not been declared in boost::optional

Fri, 17 Dec 2010 12:37:30 GMT

now also reproduced on different machine:

[67280] release branch fails to build with

./bootstrap.sh
./bjam

now more succinct and better formatted error message:

gcc.compile.c++.pch bin.v2/libs/math/build/gcc-4.3/release/threading-multi/../src/tr1/pch.hpp.gch
In file included from ./boost/optional.hpp:15,
                 from ./boost/format/internals.hpp:20,
                 from ./boost/format.hpp:38,
                 from ./boost/math/policies/error_handling.hpp:30,
                 from ./boost/math/special_functions/acosh.hpp:21,
                 from ./boost/math/special_functions.hpp:15,
                 from libs/math/build/../src/tr1/pch.hpp:9:
./boost/optional/optional.hpp: In member function ‘void boost::optional<T>::swap(boost::optional<T>&)’:
./boost/optional/optional.hpp:618: error: ‘boost::swap’ has not been declared
    "g++" -x c++-header -O3 -finline-functions -Wno-inline -Wall -pthread -fPIC -fvisibility=hidden -DBOOST_ALL_NO_LIB=1 -DBOOST_BUILD_PCH_ENABLED -DBOOST_MATH_TR1_DYN_LINK=1 -DNDEBUG -I"." -I"libs/math/src/tr1" -c -o "bin.v2/libs/math/build/gcc-4.3/release/threading-multi/../src/tr1/pch.hpp.gch" "libs/math/build/../src/tr1/pch.hpp"
...failed gcc.compile.c++.pch bin.v2/libs/math/build/gcc-4.3/release/threading-multi/../src/tr1/pch.hpp.gch...

Fri, 17 Dec 2010 12:40:37 GMT

possibly introduced by [67183]?

r67183 | andysem | 2010-12-12 12:34:12 +0100 (Sun, 12 Dec 2010) | 1 line
Changed paths:
   M /branches/release/boost/optional/optional.hpp
   M /branches/release/boost/optional/optional_io.hpp
   M /branches/release/libs/optional/test/optional_test.cpp
   M /branches/release/libs/optional/test/optional_test_io.cpp
Merged changes from trunk. Fixes #3395. Also updates swap behavior: if default constructor has no-throw guarantee, swap will use it to pr
ovide no-throw guarantee itself. operator>> behavior changed slightly so that the stream is not accessed when unrecognized character sequ
ence is detected. The stream is marked with failbit in such a case.

owner set

Fri, 17 Dec 2010 12:41:25 GMT

owner set to Andrey Semashev

reassigning to andysem on a hunch

Andrey Semashev — Fri, 17 Dec 2010 21:13:01 GMT

(In [67288]) Refs #4987. Added forward declaration of namespace-scope swap for boost::optional, this should fix GCC compilation errors. Also swap implementation now uses Boost.Utility.Swap to make use of the workarounds for some broken compilers. If it breaks for your compiler, let me know in the mentioned ticket.

status, component changed

Andrey Semashev — Fri, 17 Dec 2010 21:18:06 GMT

status new → assigned
component Building Boost → optional

Could you please verify that the trunk version works for you now?

Sat, 18 Dec 2010 12:09:48 GMT

trunk [67294] builds nicely, but trunk built nicely before!

after doing a

svn merge http://svn.boost.org/svn/boost/trunk -c 67288

the release branch now also works for me.

Please merge your fix into the release branch, then everything should be fixed.

Thanks a lot!

status changed; resolution set

Andrey Semashev — Sat, 18 Dec 2010 21:29:42 GMT

status assigned → closed
resolution → fixed

(In [67307]) Merged changes from trunk: add namespace scope swap forward declaration to fix member swap copmilation. Swap implementation now uses Boost.Utility.Swap. Fixes #4987.