Boost C++ Libraries: Ticket #5145: Fixed warning: use of logical && with constant operand; switch to bitwise & or remove constant [-Wconstant-logical-operand]

attachment set

anonymous — Mon, 31 Jan 2011 17:01:50 GMT

attachment → 0002-Fixed-warning-use-of-logical-with-constant-operand-s.patch

owner changed

Steven Watanabe — Fri, 11 Feb 2011 03:25:58 GMT

owner changed from Dave Abrahams to Andy Tompkins

Marshall Clow — Mon, 14 Feb 2011 16:41:48 GMT

Applying this patch causes two of the tests to fail (not surprisingly, since it changes the string representation when outputting as wide chars):

testing.capture-output ../../../bin.v2/libs/uuid/test/test_name_generator.test/clang-darwin-4.2.1/debug/test_name_generator.run
====== BEGIN OUTPUT ======
test_name_generator.cpp(32): test 'u == wcorrect' failed in function 'int main(int, char **)': 'c315270b-a466-5872-aca4-9626cec0f4be' != 'b9506613-2c04-512d-b8fe-bf8d0ba1b271'
test_name_generator.cpp(40): test 'u == wcorrect' failed in function 'int main(int, char **)': 'c315270b-a466-5872-aca4-9626cec0f4be' != 'b9506613-2c04-512d-b8fe-bf8d0ba1b271'
2 errors detected.
EXIT STATUS: 1
====== END OUTPUT ======

The test needs to be adjusted, too. ;-)

Marshall Clow — Mon, 14 Feb 2011 17:34:46 GMT

(In [68866]) Fix bug in wide output; Refs #5145

status, version changed; resolution set

Andy Tompkins — Mon, 30 May 2011 00:36:31 GMT

status new → closed
version Boost Development Trunk → Boost 1.47.0
resolution → fixed