id	summary	reporter	owner	description	type	status	milestone	component	version	severity	resolution	keywords	cc
5186	uuid process_characters problem	Chris Jefferson	Andy Tompkins	"In boost/uuid/name_generator.hpp, there is the method:

    void process_characters(char_type const*const characters, size_t count) {
        BOOST_ASSERT(sizeof(uint32_t) >= sizeof(char_type));

        for (size_t i=0; i<count; i++) {
            uint32_t c = characters[i];
            sha.process_byte( (c >> 0) && 0xFF );
            sha.process_byte( (c >> 8) && 0xFF );
            sha.process_byte( (c >> 16) && 0xFF );
            sha.process_byte( (c >> 24) && 0xFF );
        }
    }

The usage of ' && 0xFF ' means that all these lines just evaluate to '1', meaning all this really does is create a hash of the length of the string, except if there are any embedded NULLs in the strings.

There is an obvious fix, which is to change && to &. However, this would obviously change the strings which are generated."	Bugs	closed	To Be Determined	uuid	Boost 1.45.0	Problem	duplicate