Boost C++ Libraries: Ticket #5282: Test fixtures do not support virtual inheritance

Gennadiy Rozental — Mon, 17 Oct 2011 02:34:43 GMT

I am not sure I understand what the problem is. CUT is not a fixture. and why fixture needs virtual base classes is unclear. Please provide an example.

Wed, 09 Nov 2011 22:04:28 GMT

Ok, so if I have a class TestMe...

class TestMe
{
protected:
   bool protectedValue = 0;
   int protectedMethod(int arg) { ... }
   void someProtectedBehavior() { ... }
}

I will usually create a fixture as a subclass:

/**
 * Override methods to add test functionality
 */
class TestMeFixture : public TestMe
{
   // override production behavior for testing
   void someProtectedBehavior() { ... }
}
BOOST_FIXTURE_TEST_SUITE( MyTestSuite, TestMeFixture )
BOOST_AUTO_TEST_CASE( test_top_level_values )
{
   int expected = 123;
   BOOST_CHECK_EQUAL(expected, protectedMethod(456)); // call protected method
   BOOST_CHECK(protectedValue); // get protected value
   ...
}
BOOST_AUTO_TEST_SUITE_END()

...which is far more concise than writing a subclass as separate from the fixture, which would force you to write all sorts of getters and setters and wrappers for protected members.

Wed, 09 Nov 2011 22:20:31 GMT

Sorry, I forgot to add that TestMe extends another class:

class TestMe : public TestMeParent
{
protected:
   bool protectedValue = 0;
   int protectedMethod(int arg) { ... }
   void someProtectedBehavior() { ... }
}

...which is fine. But if the inheritance is virtual, and TestMeParent does not have a default constructor, then its constructor must be specified by every subclass at any level:

class TestMeParent
{
public:
   TestMeParent(int initValue) { ... }
}
class TestMe : public virtual TestMeParent
{
public:
   TestMe() :
      TestMeParent(678) // initializer required at every inheritance level
   {
      ...
   }
}

This breaks my fixture arrangement, because the fixture is subclassed again by the fixture macros.

Hopefully I explained it clearly enough! :)

status changed; resolution set

Gennadiy Rozental — Wed, 08 Jul 2015 05:06:15 GMT

status new → closed
resolution → wontfix

I am not sure what you recommend us to do in this case. I guess you will have to specialize your base class separately from fixture in this case.

status changed; resolution deleted

tye.zdrojewski@… — Wed, 08 Jul 2015 13:07:24 GMT

status closed → reopened
resolution wontfix

The recommendation is right in the original post: "an argument to the FIXTURE macros that would allow the tester to specify some or all of the initialization list".

Is that not do-able for some reason?

milestone changed

Raffi Enficiaud — Thu, 22 Jun 2017 22:52:37 GMT

milestone To Be Determined → Boost 1.65.0

owner, status changed

Raffi Enficiaud — Fri, 23 Jun 2017 15:42:37 GMT

owner changed from Gennadiy Rozental to Raffi Enficiaud
status reopened → new

Raffi Enficiaud — Fri, 23 Jun 2017 15:55:02 GMT

I do not get it: you are writing a fixture for being able to test protected members of TestMeParent, and you do not want to specify the constructions of TestMeParent inside your fixture.

OTOH, having an additional parameter passed to the BOOST_FIXTURE_TEST_SUITE will not help you very far here: you will still need to initialize TestMeParent in some way, and you will still need to forward whatever has been passed to the ctor of TestMe to TestMeParent.

It is a bit confusing, I am flagging this as not doing.

status changed; resolution set

Raffi Enficiaud — Fri, 23 Jun 2017 15:55:11 GMT

status new → closed
resolution → wontfix

milestone changed

Raffi Enficiaud — Fri, 23 Jun 2017 15:55:52 GMT

milestone Boost 1.65.0 → To Be Determined

tye.zdrojewski@… — Mon, 07 Aug 2017 15:52:56 GMT

you do not want to specify the constructions of TestMeParent inside your fixture

...as indicated in the description AND in the example, the virtual parent's init list is "required at every inheritance level". That would include the subclass created by the macro.

We are talking about VIRTUAL inheritance, not regular inheritance.

It is a bit confusing, I am flagging this as not doing.

Please do not close an issue because you are confused.