Boost C++ Libraries: Ticket #5289: Library that uses Boost Filesystem would not start when the stdandard C++ library does not support the current locale

attachment set

artyomtnk@… — Thu, 10 Mar 2011 14:49:37 GMT

attachment → boost_filesystem.patch

Tue, 31 May 2011 10:14:34 GMT

Duplicate of #4688?

artyomtnk@… — Tue, 31 May 2011 11:14:36 GMT

It is duplicate but the patch attached there is not correct. As even on Linux it may not start if LANG=xx_YY.UTF-8 that is not configured on this OS (locale -a) then it would fail as well.

So the patch there is wrong.

My patch handles it much better even on system when gcc does not support non-POSIX locales.

status changed

Beman Dawes — Tue, 07 Jun 2011 10:43:03 GMT

status new → assigned

I'm concerned that this patch doesn't include any test cases. I'd really like to first add additional test cases that fail with the current implementation and then pass when the patch is supplied.

Thanks,

--Beman

artyomtnk@… — Tue, 07 Jun 2011 12:08:51 GMT

I'm concerned that this patch doesn't include any test cases. I'd really like to first add additional test cases that fail with the current implementation and then pass when the patch is supplied

The simplest test that can be done under any platform is:

link the library to simple executable that does nothing.
Run it with environment variable "LANG" set to "xx_YY.UTF-8" (illegal locale) and check if the library starts (fails to start without this patch).
Check that the boost::filesystem::path's locale has UTF-8 facet (trivially by converting one wide NON-ASCII character to char.

It is very easy to reproduce this bug (by setting illegal locale environment variable) but it requires some non-trivial scripting with BBv2 (that I unfortunately not too familiar with it)

status changed; resolution set

anonymous — Fri, 29 Jul 2011 15:32:49 GMT

status assigned → closed
resolution → fixed

Fixed by changeset 72855, Fix problem of locale("") exception being thrown before main() starts on misconfigured (e.g. LANG="bad name") POSIX systems. Resolves the most serious aspect of tickets 4688, 5100, 5289.

Boost 1.47.0 was the first release to include this fix.

--Beman

bbazso@… — Tue, 25 Oct 2011 13:43:58 GMT

I do not think that this issue should be closed or perhaps another one needs to be opened, but there is definitely still a problem associated with this issue. When I call the function:

boost::filesystem::create_directories (iDirectory);

To create a directory, I get the error:

locale::facet::_S_create_c_locale name not valid

I am running Boost 1.47.0 on the following system:

DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=9.04
DISTRIB_CODENAME=jaunty
DISTRIB_DESCRIPTION="Ubuntu 9.04"

I manually patched Boost 1.47.0 with the patch in this issue and it solves the issue. So I think that a issue should be opened or this one re-opened.