Boost C++ Libraries: Ticket #5351: interrupt a future get boost::unknown_exception

owner, status, summary changed; cc set

viboes — Sun, 04 Dec 2011 18:36:34 GMT

cc viboes added
owner changed from Anthony Williams to viboes
status new → assigned
summary [boost::thread] interrupt a future get boost::unknown_exception → interrupt a future get boost::unknown_exception

attachment set

viboes — Sun, 11 Dec 2011 01:26:49 GMT

attachment → 5351.diff

a possible solution

viboes — Sun, 11 Dec 2011 01:27:28 GMT

I have reached to compile the example with some variants.

It seems the problem comes from the fact that packaged_task catch every exception and store it to rethrow in the wait() function using boost::rethrow_exception. As thread_interrupted doesn't inherits from std/boost::exception the throw exception is unknown_exception.

                if(rethrow && exception)
                {
                    boost::rethrow_exception(exception);
                }

A solution could be to catch specifically thread_interrupted and store this fact.

When wait is called, a test if the thread has been interrupted is done so that the exception thread_interrupted is thrown. The single problem is that the this new exception doesn't contains from where the initial thread_interrupted was thrown.

See the attached patch for the complete solution.

attachment set

viboes — Sun, 11 Dec 2011 01:29:55 GMT

attachment → test_5351.cpp

The adapted test

viboes — Mon, 19 Dec 2011 21:53:50 GMT

There is also another patch that needs to be applied. See detail/move.hpp.diff file.

attachment set

viboes — Mon, 19 Dec 2011 21:54:38 GMT

attachment → detail_move.hpp.diff

type changed

viboes — Thu, 29 Dec 2011 14:14:34 GMT

type Bugs → Patches

milestone changed

viboes — Sat, 07 Jan 2012 23:03:49 GMT

milestone To Be Determined → Boost 1.49.0

viboes — Tue, 17 Jan 2012 06:37:43 GMT

Committed in trunk at revision [76543]. However the issue seems to be also on Windows platforms.

anonymous — Wed, 18 Jan 2012 02:09:11 GMT

catch (boost::thread_interrupted& exc)

if the caller of fi.get() is a boost::thread and is interrupted, get() will throw thread_interrupted. but the future is interrupted now, not the caller. so I recommend get() throw a new class boost::future_interrupted use BOOST_THROW_EXCEPTION.

15
16	int main(int argc, char** argv)
17	{
18	  boost::packaged_task<int> pt(&foo);
19	  boost::unique_future<int> fi = pt.get_future();
20	  boost::thread task(boost::move(pt)); // launch task on a thread
21
22	  task.interrupt();
23
24	  try
25	  {
26	    int v = fi.get();
27	  }
28	  catch (boost::thread_interrupted& exc)
29	  {
30	    std::cout << "OK: " << std::endl;
31	    return 0;
32	  }
33	  catch (boost::exception& exc)
34	  {
35	    std::cout << __LINE__ << " ERROR: " << boost::diagnostic_information(exc) << std::endl;
36	    return 1;
37	  }
38	  catch (...)
39	  {
40	    std::cout << __LINE__ << " ERROR: " << std::endl;
41	    return 2;
42	  }
43	  std::cout << __LINE__ << " ERROR: " << std::endl;
44	  return 3;
45	}

status, milestone changed; resolution set

viboes — Mon, 28 May 2012 15:40:56 GMT

status assigned → closed
resolution → fixed
milestone Boost 1.49.0 → Boost 1.50.0

Committed in release branch at [78543]