Boost C++ Libraries: Ticket #5493: Replaces literal pi by boost::math::constants::pi<>()

attachment set

Thu, 21 Apr 2011 00:18:08 GMT

attachment → cauchy_dist.patch

attachment set

Thu, 21 Apr 2011 00:18:23 GMT

attachment → gamma_dist.patch

attachment set

Thu, 21 Apr 2011 00:18:36 GMT

attachment → normal_dist.patch

owner changed; cc set

Bryce Adelstein Lelbach — Thu, 21 Apr 2011 00:49:22 GMT

cc blelbach@… added
owner changed from No-Maintainer to John Maddock

owner changed

Bryce Adelstein Lelbach — Thu, 21 Apr 2011 00:50:39 GMT

owner changed from John Maddock to Steven Watanabe

John Maddock — Mon, 25 Apr 2011 08:44:30 GMT

I wonder if this really makes any difference? The precision of the value of pi in a random number generator is presumably not so important?

Mon, 25 Apr 2011 15:07:55 GMT

Hi John,

This is the reason i tagged the patch as "cosmetic". Use literal values, it's not good practice as we know.

Regards, Júlio.

Steven Watanabe — Mon, 25 Apr 2011 15:35:14 GMT

Replying to johnmaddock:

I wonder if this really makes any difference? The precision of the value of pi in a random number generator is presumably not so important?

The Random library only works with float, double, and long double anyway. I had to make some adjustments to test with NTL and I didn't keep those changes.

status changed; resolution set

Steven Watanabe — Thu, 13 Mar 2014 00:33:30 GMT

status new → closed
resolution → wontfix