Boost C++ Libraries: Ticket #5550: Missing initializer warning in date_time/date_facet.hpp

component changed; owner set

Wed, 18 May 2011 19:20:29 GMT

owner set to az_sw_dude
component None → date_time

Setting component to date_time

Mon, 30 May 2011 09:55:18 GMT

Can I work on this bug?

attachment set

Fri, 10 Jun 2011 11:37:57 GMT

attachment → patch_for_ticket#5550.diff

Patch for the bug.

cc set

Fri, 01 Jul 2011 10:52:42 GMT

cc manish.mulimani@… added

cc, severity changed

Fri, 28 Oct 2011 22:43:30 GMT

cc derek@… added
severity Cosmetic → Problem

This is breaking our compilation, so I am upgrading it from cosmetic to a problem. Please submit patch.

Marshall Clow — Wed, 26 Sep 2012 16:58:00 GMT

(In [80710]) Use memset instead of default constructor (std::tm) for deficient compilers; Refs #5550

status changed; resolution set

Marshall Clow — Sun, 30 Sep 2012 23:25:27 GMT

status new → closed
resolution → fixed

(In [80797]) Merge bug fixes to release; Fixes #5550 Fixes #6136 Fixes #6513 Fixes #7111 Fixes #7112 Fixes #7113 Fixes #7342 Fixes #7426

status, version changed; resolution deleted

Wed, 19 Jun 2013 14:22:27 GMT

status closed → reopened
version Boost 1.46.1 → Boost 1.54.0
resolution fixed

This problem is there at two more places in another file (boost 1.54 beta1), giving the same errors/warnings as above.

/date_time/strings_from_facet.hpp:53:20: warning: missing initializer for member ‘tm::tm_gmtoff’ [-Wmissing-field-initializers] (and ten more like it)

/date_time/strings_from_facet.hpp:106:20: warning: missing initializer for member ‘tm::tm_zone’ [-Wmissing-field-initializers] (and ten more like it)

Now, changeset https://svn.boost.org/trac/boost/changeset/80797 suggest the change from

tm tm_value = {};

std::tm dtm; std::memset(&dtm, 0, sizeof(dtm));

I've made this change (at two places) and that silences all related warnings. Using the more obvious tm_value = {0,0,0,0,0,0,0,0,0} is not a good idea since some implementations add their own values at the end of the struct.

How to reproduce:

#include "date_time/posix_time/posix_time.hpp" int main(){}

compile with gcc4.7.2, default options.

Marshall Clow — Wed, 19 Jun 2013 15:36:33 GMT

(In [84835]) Fixed more compiler warnings; Refs #5550

status changed; resolution set

Marshall Clow — Fri, 21 Jun 2013 15:04:14 GMT

status reopened → closed
resolution → fixed

(In [84860]) Merge bug fixes to release. Fixes #6136. Fixes #5550