Boost C++ Libraries: Ticket #5687: some evaluation functions do not work with BOOST_RESULT_OF_USE_DECLTYPE

Wed, 13 Jul 2011 04:53:19 GMT

phoenix::new_ does not work with BOOST_RESULT_OF_USE_DECLTYPE, too.

status changed

Thomas Heller — Wed, 13 Jul 2011 06:26:13 GMT

status new → assigned

status changed; resolution set

Thomas Heller — Wed, 13 Jul 2011 07:24:56 GMT

status assigned → closed
resolution → fixed

Thanks for the report, fixed on trunk.

version changed

Thomas Heller — Wed, 13 Jul 2011 07:52:16 GMT

version Boost Development Trunk → Boost 1.47.0

Wed, 13 Jul 2011 08:26:54 GMT

Confirmed the fix. Thanks for your quick work, Thomas!

BTW, many other structs (xxxx_eval) need this kind of fixes. Could you run the tests (libs/phoenix/test) with defining BOOST_RESULT_OF_USE_DECLTYPE? Then, you'll see many compiler errors.

Of course, if you want, I can run the tests and report which files need to be fixed. (But it might take some time, since my knowledge about bjam is scarse.)

status, summary changed; resolution deleted

Thomas Heller — Wed, 13 Jul 2011 08:41:45 GMT

status closed → reopened
resolution fixed
summary phoenix::construct does not work with BOOST_RESULT_OF_USE_DECLTYPE → some evaluation functions do not work with BOOST_RESULT_OF_USE_DECLTYPE

Something went wrong then, thought i ran the tests with this compiler flag. Will check it again. FWIW, this is how my user_config.jam (in my home directory) looks like for gcc with C++0x enabled:

using gcc
    : c++0x
    : /usr/bin/g++
    : <compileflags>"-DBOOST_RESULT_OF_USE_DECLTYPE --std=c++0x -ansi -pedantic -Wextra -Wno-long-long -Wno-sign-compare -Wno-unused-function -Wno-deprecated -Wno-missing-braces"
    ;

invoke bjam with toolset=gcc-c++0x and it should work.

Bug is reopened until everything else is fixed.

Thomas Heller — Wed, 13 Jul 2011 08:56:56 GMT

update: It must read:

using gcc
    : c++0x
    : /usr/bin/g++
    : <compileflags>"-DBOOST_RESULT_OF_USE_DECLTYPE -ansi -pedantic --std=c++0x -Wextra -Wno-long-long -Wno-sign-compare -Wno-unused-function -Wno-deprecated -Wno-missing-braces"
    ;

Wed, 13 Jul 2011 09:05:47 GMT

Just to be clear: the bugs in phoenix::construct and phoenix::new_ are already fixed (and no new bugs are created by the fix).

In my last comment, I just reported that there are similar bugs in phoenix. For example, libs/phoenix/test/statement/if_tests.cpp fails to compile.

Sorry for confusing you. Should I make another ticket?

Thomas Heller — Wed, 13 Jul 2011 09:10:11 GMT

No confusion happened ;)

I renamed the ticket. So I think it should be fine. Also, the fix is almost done ... running tests right now.

Sun, 17 Jul 2011 03:39:22 GMT

Ah, I missed the new title of the ticket!

And thanks for the hint about bjam, now I can run the tests with BOOST_RESULT_OF_USE_DECLTYPE :)

milestone changed

Thomas Heller — Sun, 09 Oct 2011 02:47:40 GMT

milestone Boost 1.48.0 → To Be Determined

Michel Morin — Tue, 15 May 2012 13:30:07 GMT

Thomas, what is the current situation of this ticket?

In trunk, decltype-based result_of is enabled by default on a compiler with N3276 decltype support (such as clang 3.1). This means that some existing codes fail to compile on such compilers. (Users have an option to disable decltype-based result_of by defining BOOST_RESULT_OF_USE_TR1.)

I tested Boost.Phoenix on clang (which implements N3276 decltype) in a C++11 mode. The following tests fail to compile:

libs/phoenix/test/bind_not_test.test
libs/phoenix/test/bind_rv_sp_test.test
libs/phoenix/test/bind_stateful_test.test
libs/phoenix/test/bind_test.test
libs/phoenix/test/bug3289.test
libs/phoenix/test/dynamic_tests.test
libs/phoenix/test/exceptions.test
libs/phoenix/test/if_tests.test
libs/phoenix/test/lambda_tests.test
libs/phoenix/test/loops_tests.test
libs/phoenix/test/member.test
libs/phoenix/test/new_delete_tests.test
libs/phoenix/test/switch_tests.test

You can see the error messages at http://www.boost.org/development/tests/trunk/developer/phoenix.html (clang-cxx11-r156741 test runner).

Also, some tests of Boost.Spirit fail to compile due to the dependency on Boost.Phoenix:

libs/spirit/test/lex_regression_file_iterator3-p3.test

Tue, 28 Aug 2012 01:43:00 GMT

I also encountered this problem in 1.51 release, so it seems to still need fixing.