Boost C++ Libraries: Ticket #5724: "0 + 0" and "0 - 0" lead to a compile time error

component changed; owner set

Wed, 20 Jul 2011 12:05:32 GMT

owner set to viboes
component None → ratio

status changed; resolution set

viboes — Fri, 19 Aug 2011 15:40:47 GMT

status new → closed
resolution → fixed

(In [73918]) ratio: fix #5724: 0 + 0 and 0 - 0 lead to a compile time error

viboes — Fri, 19 Aug 2011 15:41:12 GMT

(In [73919]) ratio: fix #5724: 0 + 0 and 0 - 0 lead to a compile time error

anonymous — Fri, 19 Aug 2011 15:43:39 GMT

I have added two partial specialization that solve the issue.

template <class R> struct ratio_add<R, ratio<0> > {

typedef R type;

};

template <class R> struct ratio_subtract<R, ratio<0>> {

typedef R type;

};

to the file boost/ratio/detail/overflow_helpers.hpp.

Sorry for the late replay. Thanks for catching this.

I have committed this and two test on trunk: Committed revision 73918. Committed revision 73919.

Sat, 20 Aug 2011 11:12:59 GMT

The solution doesn't work with ratio<0, 2> and so on, I think. The following is better:

template <class R, boost::intmax_t D> struct ratio_add<R, ratio<0, D> > {
    typedef R type;
};
template <class R, boost::intmax_t D> struct ratio_subtract<R, ratio<0, D> > {
    typedef R type;
};

status changed; resolution deleted

Sun, 02 Oct 2011 19:45:09 GMT

status closed → reopened
resolution fixed

status changed; resolution set

viboes — Tue, 01 Nov 2011 20:56:38 GMT

status reopened → closed
resolution → fixed

Hi, to late replying to your comments :(

I will try to put this in the release, bit it would be easier if you can post the issue on the ML.

Fixed in trunk

Committed revision 75240.