Boost C++ Libraries: Ticket #5731: Failure in boost/numeric/conversion when compiled without exceptions

attachment set

pmachata@… — Fri, 22 Jul 2011 14:34:21 GMT

attachment → boost-1.47.0-exceptions.patch

Proposed fix

component changed; owner set

pmachata@… — Fri, 22 Jul 2011 14:36:17 GMT

owner set to Douglas Gregor
component None → numeric

anonymous — Sun, 27 Nov 2011 09:48:27 GMT

can somebody review this patch? the issue with kdeedu-rocs is still valid with 1.48

Robert Ramey — Wed, 04 Jan 2012 20:34:17 GMT

I looked at this and I don't like it.

I drags in a bunch of boost.exception stuff we're not using. This problem came up when BOOST_THROW_EXCEPTION was redefined by the authors of Boost Exception and surprised a lot of us with bloat code and other problems.

Think about this some more.

Robert Ramey

Mon, 23 Jan 2012 14:20:29 GMT

An exception is being thrown in header file. There's an existing tool for that in boost, boost::throw_exception. Many other (boost) libraries do it like that (though admittedly not all). It's a correctness issue, too, that code is invalid when compiled with -fno-exceptions. I don't think boost should support every odd compiler flag out there, but it seems that support for this one is well established.

version changed; cc set

Antony Polukhin — Sat, 11 Feb 2012 08:48:45 GMT

cc antoshkka@… added
version Boost 1.47.0 → Boost 1.50.0

Replying to ramey:

I looked at this and I don't like it.

I drags in a bunch of boost.exception stuff we're not using. This problem came up when BOOST_THROW_EXCEPTION was redefined by the authors of Boost Exception and surprised a lot of us with bloat code and other problems.

There is a patch for BOOST_THROW_EXCEPTION that reduces code bloat #6450
Support for noexception build is really required, because such builds are widely used on embedded platforms and are part of C++ corporate style in some organizations.

I would advise to use BOOST_THROW_EXCEPTION instead of boost::throw_exception, because it gives better control to user, better debugging abilities and is meant to be used in all libraries.

This is a very popular bug and a lot of users want it fixed! It is duplicated in tickets #5076, #5393, #5800.

Please, fix it till 1.50 release or allow me to fix it (it is a trivial bug).

status changed; resolution set

Antony Polukhin — Mon, 05 Mar 2012 17:11:23 GMT

status new → closed
resolution → fixed

(In [77234]) Fixes #5731, fixes #5076, fixes #5393, fixes #5800 Now numeric_cast (and lexical_cast) can be compiled with disabled exceptions