Boost C++ Libraries: Ticket #5732: small bugfixes and refactoring for lexical_cast

status changed; resolution set

Antony Polukhin — Sat, 23 Jul 2011 15:55:57 GMT

status new → closed
resolution → fixed

(In [73313]) Fixes #5732.

reduces templates count
leaves only one lexical converting class (at least for modern compilers)
fixes small TODOs and XXXs from source code
makes lexical_stream_limited_src more readable
updates status/explicit-failures-markup.xml
makes lexical_cast_inf_nan_test.cpp pass on Itanium pltform
makes lexical_cast able to convert signed and unsigned chars to wchar_t and updates lexical_cast_wchars_test

Antony Polukhin — Sun, 24 Jul 2011 09:42:11 GMT

(In [73323]) Fixes #5732.

fixes performance regression, that was added by previous commit
fixes float types preformance regression for old compilers

Antony Polukhin — Sun, 24 Jul 2011 10:57:02 GMT

(In [73328]) Fixes #5732.

fixes some warnings and bugs for VC

attachment set

Jürgen Hunold — Mon, 25 Jul 2011 09:06:34 GMT

attachment → lex.tar.gz

testcase for std::vector<char>

Jürgen Hunold — Mon, 25 Jul 2011 09:08:13 GMT

the last patches broke some of my code which uses lexical_cast to parse values from std::vector<char>

Something as simple as

std::vector<char> buffer; return boost::lexical_cast<int>(&buffer[0]);

fails with

BOOST_ROOT/boost/lexical_cast.hpp:1091:43: error: no matching constructor for initialization of 'std::basic_ostream<char>'

std::basic_ostream<CharT> stream(&stringbuffer);

^~

this is the start of the clang diagnostic.

Both gcc (Ubuntu 4.6.0-3~ppa1) 4.6.1 20110409 (prerelease) and clang version 3.0 (trunk 135897)

output contained in attached testcase lex.tar.gz

Antony Polukhin — Mon, 25 Jul 2011 15:13:40 GMT

(In [73357]) Fixes #5732.

fixes compilation errors for nonconst char arrays

Antony Polukhin — Mon, 25 Jul 2011 15:25:44 GMT

Replying to jhunold:

the last patches broke some of my code which uses lexical_cast to parse values from std::vector<char>

Fixed in [73357]. Added some test cases. Thanks again for the testing.

Antony Polukhin — Tue, 26 Jul 2011 18:51:41 GMT

(In [73384]) Fixes #5732.

fixes compilation errors pgi compiler
fixes some bugs for MinGW compiler

Antony Polukhin — Wed, 27 Jul 2011 15:56:53 GMT

(In [73401]) Fixes #5732.

one more try to fix compilation errors on pgi compiler

Antony Polukhin — Fri, 29 Jul 2011 19:33:21 GMT

(In [73435]) Fixes #5732.

one more try to fix compilation errors on pgi compiler

Antony Polukhin — Sat, 30 Jul 2011 16:47:33 GMT

(In [73446]) Fixes #5732.

at least compiles on pgi

Antony Polukhin — Sun, 07 Aug 2011 17:38:36 GMT

(In [73601]) Fixes #5732.

some fixes for WinCE
updated explicit failures markup

Antony Polukhin — Wed, 10 Aug 2011 18:58:09 GMT

(In [73640]) Fixes #5732.

suppress compilation warnings, if the compiler requires a return, even when it can never be reached