Boost C++ Libraries: Ticket #5738: Default-constructed mapped_region address is not NULL

status changed; resolution set

Ion Gaztañaga — Fri, 23 Dec 2011 13:48:56 GMT

status new → closed
resolution → fixed

Thanks fixed in trunk at revision: 76118

status changed; resolution deleted

Andrey Semashev — Fri, 23 Dec 2011 14:01:23 GMT

status closed → reopened
resolution fixed

I see you changed the documentation rather than implementation. I think it would be better to make initial address to be NULL on all platforms rather than some unspecified value. Sorry, I didn't make my intention clear in the ticket. I'll reopen it so that it doesn't get lost.

anonymous — Sat, 24 Dec 2011 10:08:22 GMT

I don't like the idea of making the address null on all platforms. In UNIX MAP_FAILED is not NULL and I don't think I should add a branch in the inline get_address to convert map_failed to null, confusing UNIX users. I've committed another change, creating an additional invalid_address() static function that returns a portable invalid address constant (0 in windows, MAP_FAILED in unix). Let me know if you think this can be enough to close the bug.

Andrey Semashev — Sat, 24 Dec 2011 13:16:26 GMT

I didn't mean to add a branch to get_address. The idea was to process MAP_FAILED internally, when mmap is called, and always use NULL to indicate the invalid address to users. I think NULL is the commonly used value for pointers to indicate address validity, so there is no need to introduce another constant for this. In fact, I consider MAP_FAILED constant as a bad legacy of the mmap function interface. I'll try to prepare a patch to illustrate my suggestion.

attachment set

Andrey Semashev — Sat, 24 Dec 2011 14:06:15 GMT

attachment → mapped_region.patch

The patch that fixes initial address of mapped region.

Andrey Semashev — Sat, 24 Dec 2011 14:08:08 GMT

See the attached patch. I removed the invalid_address function as there is no need for it anymore. If you feel for it, you can leave it there, in which case it should always return NULL on all platforms.

Ion Gaztañaga — Tue, 27 Dec 2011 09:39:04 GMT

Thanks for the patch, tested and committed (revision 76200).

status changed; resolution set

Ion Gaztañaga — Wed, 18 Jan 2012 20:51:33 GMT

status reopened → closed
resolution → fixed

Merged to release branch.