Boost C++ Libraries: Ticket #5741: Declare sequence_index as non-copyable

Sat, 30 Jul 2011 13:14:32 GMT

Follow up:

The fix (to tell BOOST_FOREACH to avoid coping sequenced_index) needs forward declaration of foreach::is_noncopyable.

namespace boost{ namespace foreach{
template<typename T> struct is_noncopyable; // forward declaration
template<typename SuperMeta,typename TagList>
struct is_noncopyable<
  multi_index::detail::sequenced_index<SuperMeta, TagList>
>:mpl::true_
{
};
}}

Sat, 30 Jul 2011 13:16:17 GMT

Other index types (ordered_index, hashed_index, random_access_index) also need this fix.

attachment set

Sun, 31 Jul 2011 06:34:31 GMT

attachment → multi_index_foreach_support_fix.patch

A patch for hashed_index, ordered_index, random_access_index and sequenced_index (against trunk).

Sun, 31 Jul 2011 06:36:17 GMT

A patch attached, and here is a test case:

#include <iostream>
#include <boost/multi_index_container.hpp>
#include <boost/multi_index/hashed_index.hpp>
#include <boost/multi_index/ordered_index.hpp>
#include <boost/multi_index/random_access_index.hpp>
#include <boost/multi_index/sequenced_index.hpp>
#include <boost/foreach.hpp>
#include <boost/range/value_type.hpp>
template <typename Range>
void display_range(Range const& rng)
{
    BOOST_FOREACH(typename boost::range_value<Range>::type x, rng) {
        std::cout << x << std::endl;
    }
}
int main (int argc, char* argv[])
{
    using namespace boost::multi_index;
    multi_index_container<int, indexed_by<
        hashed_unique<identity<int> >
      , hashed_non_unique<identity<int> >
      , ordered_unique<identity<int> >
      , ordered_non_unique<identity<int> >
      , random_access<>
      , sequenced<>
    > > cont;
    display_range(cont.get<0>());
    display_range(cont.get<1>());
    display_range(cont.get<2>());
    display_range(cont.get<3>());
    display_range(cont.get<4>());
    display_range(cont.get<5>());
    return 0;
}

Without the patch, this test fails to compile on compilers that use BOOST_FOREACH_RUN_TIME_CONST_RVALUE_DETECTION , such as gcc-4.6 and clang (both in C++03 mode).

status changed; resolution set

Joaquín M López Muñoz — Wed, 03 Aug 2011 06:31:30 GMT

status new → closed
resolution → fixed

(In [73498]) fixed #5741