Boost C++ Libraries: Ticket #5763: Segmentation fault in ASIO signal handler

attachment set

Mon, 08 Aug 2011 07:50:43 GMT

attachment → boost_1_47_0-intel-segfault-in-asio-signal.diff

Mon, 08 Aug 2011 08:00:39 GMT

Sorry. Typo in compiler version. Compiler Intel Composer XE 12.0.4

chris_kohlhoff — Mon, 08 Aug 2011 08:31:51 GMT

Thank you for providing a patch. However, without a test case, I cannot confirm that this is the correct fix. Can you please supply a small test program that can be used to reproduce the error.

severity, milestone changed

chris_kohlhoff — Mon, 08 Aug 2011 08:32:12 GMT

severity Regression → Problem
milestone Boost 1.48.0 → To Be Determined

Mon, 08 Aug 2011 08:49:27 GMT

Test case: http://www.boost.org/doc/libs/1_47_0/doc/html/boost_asio/examples.html "HTTP Server" Segmentation fault on recived SIGINT.

chris_kohlhoff — Mon, 08 Aug 2011 09:54:44 GMT

Please also specify the target platform, architecture (32 or 64 bit) and compiler command line used.

Mon, 08 Aug 2011 11:00:30 GMT

Problem platform: openSUSE 11.3 x86 (32 bit)

Boost built by system gcc 4.5.0, application is built by Intel 12.0.4

Command line:

icpc -O3 -g -lboost_thread -lboost_system *.cpp

icpc -gxx-name=g++-4.3 -O3 -g -lboost_thread -lboost_system *.cpp

chris_kohlhoff — Mon, 08 Aug 2011 13:23:12 GMT

I was able to reproduce the issue, and I believe the correct fix is to apply the following change to asio/include/asio/detail/gcc_x86_fenced_block.hpp:

@@ -43,8 +43,12 @@ public:
 private:
   static int barrier()
   {
-    int r = 0;
-    __asm__ __volatile__ ("xchgl %%eax, %0" : "=m" (r) : : "memory", "cc");
+    int r = 0, m = 1;
+    __asm__ __volatile__ (
+        "xchgl %0, %1" :
+        "=r"(r), "=m"(m) :
+        "0"(1), "m"(m) :
+        "memory", "cc");
     return r;
   }
 };

Can you please try this change and let me know if it also corrects the issue for you.

Note that using the gcc_sync_fenced_block class does improve performance slightly, so I will also look to include your patch in the near future.

Mon, 08 Aug 2011 13:40:39 GMT

Your patch fixes a bug.

Wed, 17 Aug 2011 19:14:01 GMT

Tell please how there are affairs with bug fix?

Wed, 07 Sep 2011 09:32:06 GMT

Tell please how there are affairs with bug fix?

chris_kohlhoff — Sat, 08 Oct 2011 21:31:29 GMT

(In [74822]) Fix crash due to gcc_x86_fenced_block that shows up when using the Intel C++ compiler. Refs #5763

status changed; resolution set

chris_kohlhoff — Sun, 09 Oct 2011 22:00:09 GMT

status new → closed
resolution → fixed

(In [74863]) Merge from trunk...

Fix compile error in regex overload of async_read_until.hpp. Fixes #5688

Explicitly specify the signal() function from the global namespace. Fixes #5722

Don't read the clock unless the heap is non-empty.

Change the SSL buffers sizes so that they're large enough to hold a complete TLS record. Fixes #5854

Make sure the synchronous null_buffers operations obey the user's non_blocking setting. Fixes #5756

Set size of select fd_set at runtime when using Windows.

Disable warning due to const qualifier being applied to function type.

Fix crash due to gcc_x86_fenced_block that shows up when using the Intel C++ compiler. Fixes #5763

Specialise operations for buffer sequences that are arrays of exactly two buffers.

Initialise all OpenSSL algorithms.

Fix error mapping when session is gracefully shut down.

Various performance improvements:

Split the task_io_service's run and poll code.

Use thread-local operation queues in single-threaded use cases (i.e. concurrency_hint is 1) to eliminate a lock/unlock pair.

Only fence block exit when a handler is being run directly out of the io_service.

Prefer x86 mfence-based fenced block when available.

Use a plain ol' long for the atomic_count when all thread support is disabled.

Allow some epoll_reactor speculative operations to be performed without holding the lock.

Improve locality of reference by performing an epoll_reactor's I/O operation immediately before the corresponding handler is called. This also improves scalability across CPUs when multiple threads are running the io_service.

Pass same error_code variable through to each operation's complete() function.

Optimise creation of and access to the io_service implementation.

Remove unused state in HTTP server examples.

Add latency test programs.