id	summary	reporter	owner	description	type	status	milestone	component	version	severity	resolution	keywords	cc
5830	mutex.inl: extraneous use of GetVersionEx	anonymous	Anthony Williams	"Index: mutex.inl
===================================================================
RCS file: /cvsroot/boost/boost/libs/thread/src/mutex.inl,v
retrieving revision 1.9
diff -r1.9 mutex.inl
21,28c21,34
<     OSVERSIONINFO version_info = {sizeof(OSVERSIONINFO)};
<     ::GetVersionEx(&version_info);
<     if (version_info.dwPlatformId == VER_PLATFORM_WIN32_NT && 
<         version_info.dwMajorVersion >= 4)
<     {
<         if (HMODULE kernel_module = GetModuleHandle(TEXT(""KERNEL32.DLL"")))
<             g_TryEnterCriticalSection = reinterpret_cast<TryEnterCriticalSection_type>(GetProcAddress(kernel_module, TEXT(""TryEnterCriticalSection"")));
<     }
---
>    // No need for this test since Boost is using GetModuleHandle/GetProcAddress. 
>     //OSVERSIONINFO version_info = {sizeof(OSVERSIONINFO)};
>     //::GetVersionEx(&version_info);
>     //if (version_info.dwPlatformId == VER_PLATFORM_WIN32_NT && 
>     //    version_info.dwMajorVersion >= 4)
>     //{
>     //    if (HMODULE kernel_module = GetModuleHandle(TEXT(""KERNEL32.DLL"")))
>     //        g_TryEnterCriticalSection = reinterpret_cast<TryEnterCriticalSection_type>(GetProcAddress(kernel_module, TEXT(""TryEnterCriticalSection"")));
>     //}
>    
>    // The GetModuleHandle function returns a handle to KERNEL32.DLL without incrementing its reference count
>     if (HMODULE kernel_module = GetModuleHandle(TEXT(""KERNEL32.DLL""))) {
>         g_TryEnterCriticalSection = reinterpret_cast<TryEnterCriticalSection_type>(GetProcAddress(kernel_module, TEXT(""TryEnterCriticalSection"")));
>    }
"	Support Requests	closed	To Be Determined	thread	Boost 1.47.0	Problem	invalid		noloader@…