Boost C++ Libraries: Ticket #583: Fixes for build on IBM pSeries for AIX and Linux

Douglas Gregor — Thu, 09 Mar 2006 16:18:06 GMT

Logged In: YES
user_id=249098
I have a few minor comments on the patch:
1) <optimization>speed is a feature that is meant to be common across all
toolsets, so it should not be removed. It could translate to -O3 or -O4,
perhaps.
2) <runtime-link>static is another feature that is meant to be common. Can
it not be supported on XL C++?

severity, milestone set

Thomas Witt — Thu, 24 May 2007 18:03:11 GMT

severity → Showstopper
milestone → Boost 1.34.1

owner, status changed

Thomas Witt — Fri, 25 May 2007 17:52:17 GMT

owner changed from Vladimir Prus to Thomas Witt
status assigned → new

attachment set

Thomas Witt — Thu, 31 May 2007 16:58:01 GMT

attachment → boost_1_34_0_ibm.udiff

attachment set

Thomas Witt — Thu, 31 May 2007 18:10:04 GMT

attachment → boost-date_time-date_generators_hpp.patch

attachment set

Thomas Witt — Thu, 31 May 2007 18:10:44 GMT

attachment → boost-function_hpp.patch

attachment set

Thomas Witt — Thu, 31 May 2007 18:11:20 GMT

attachment → boost-numeric-interval-detail-ppc_rounding_control_hpp.patch

attachment set

Thomas Witt — Thu, 31 May 2007 18:11:32 GMT

attachment → boost-python-module_init_hpp.patch

attachment set

Thomas Witt — Thu, 31 May 2007 18:11:46 GMT

attachment → boost-regex-v4-basic_regex_hpp.patch

attachment set

Thomas Witt — Thu, 31 May 2007 18:12:15 GMT

attachment → boost-tr1-detail-config_hpp.patch

attachment set

Thomas Witt — Thu, 31 May 2007 18:12:30 GMT

attachment → libs-concept_check-stl_concept_covering_cpp.patch

attachment set

Thomas Witt — Thu, 31 May 2007 18:12:51 GMT

attachment → libs-filesystem-src-operations_cpp.patch

attachment set

Thomas Witt — Thu, 31 May 2007 18:13:09 GMT

attachment → libs-graph-src-graphviz_digraph_lex_cpp.patch

attachment set

Thomas Witt — Thu, 31 May 2007 18:13:22 GMT

attachment → libs-graph-src-graphviz_graph_lex_cpp.patch

attachment set

Thomas Witt — Thu, 31 May 2007 18:13:32 GMT

attachment → libs-mpl-test-integral_c_cpp.patch

attachment set

Thomas Witt — Thu, 31 May 2007 18:13:43 GMT

attachment → libs-python-test-select_from_python_test_cpp.patch

attachment set

Thomas Witt — Thu, 31 May 2007 18:14:02 GMT

attachment → libs-test-test-prg_exec_fail2_cpp.patch

attachment set

Thomas Witt — Thu, 31 May 2007 18:14:13 GMT

attachment → tools-build-v2-tools-python_jam.patch

attachment set

Thomas Witt — Thu, 31 May 2007 18:15:27 GMT

attachment → tools-build-v2-tools-vacpp_jam.patch

attachment set

Thomas Witt — Thu, 31 May 2007 18:15:44 GMT

attachment → tools-build-v2-util-os_jam.patch

attachment set

Thomas Witt — Thu, 31 May 2007 18:16:04 GMT

attachment → tools-regression-compiler_status_cpp.patch

Thomas Witt — Thu, 31 May 2007 18:16:55 GMT

Split patch in multiple files for easier review.

description changed

René Rivera — Fri, 01 Jun 2007 15:45:25 GMT

description modified (diff)

The build related patches applied to RC branch:

tools-build-v2-tools-python_jam.patch (1.1 kB) - added by witt on 05/31/07 14:14:13. tools-build-v2-tools-vacpp_jam.patch (4.7 kB) - added by witt on 05/31/07 14:15:27. tools-build-v2-util-os_jam.patch (485 bytes) - added by witt on 05/31/07 14:15:44.

Merging changes back to HEAD now.

Thomas Witt — Fri, 01 Jun 2007 16:12:44 GMT

Applied the following to RC_1_34_0

patching file boost/function.hpp patching file libs/concept_check/stl_concept_covering.cpp patching file boost/date_time/date_generators.hpp patching file libs/graph/src/graphviz_digraph_lex.cpp patching file libs/graph/src/graphviz_graph_lex.cpp patching file libs/filesystem/src/operations.cpp patching file boost/tr1/detail/config.hpp

attachment set

Thomas Witt — Fri, 01 Jun 2007 16:29:47 GMT

attachment → Jamfile.v2.patch

This replaces libs-mpl-test-integral_c_cpp.patch (486 bytes) - added by witt on 05/31/07 14:13:32.

Thomas Witt — Fri, 01 Jun 2007 16:32:14 GMT

Applied Jamfile.v2.patch (420 bytes) - added by witt on 06/01/07 12:29:47 to RC_1_34_0.

Thomas Witt — Fri, 01 Jun 2007 16:41:36 GMT

Applied libs-test-test-prg_exec_fail2_cpp.patch (510 bytes) - added by witt on 05/31/07 14:14:02 to RC_1_34_0.

Thomas Witt — Tue, 05 Jun 2007 17:29:02 GMT

Applied boost-regex-v4-basic_regex_hpp.patch (0.9 kB) - added by witt on 05/31/07 14:11:46 to RC_1_34_0.

Dave Abrahams — Tue, 05 Jun 2007 17:37:51 GMT

I have no problem with the 2nd Boost.Python patch. The first one essentially rips out a mechanism that we had to have on AIX to get things to work (because of its different linking model) and spent a great deal of time developing. I'm a little reluctant to apply that patch without having any explanation of why the mechanism is no longer needed. It's always possible they adjusted some flags in the toolset; if so I'm OK with it. However, if we're going to rip that thing out, we should also remove the aix_init_module.cpp source file from CVS and from Boost.Python's Jamfile.

Two further notes:

"It also adds a bunch of the latest option supported by the V8 compiler" probably implies we're breaking compatibility with earlier versions of this compiler.
This is an awfully large patchset to apply for a point release :)

Thomas Witt — Thu, 07 Jun 2007 18:04:52 GMT

Applied the following patches to RC_1_34_0:

tools-regression-compiler_status_cpp.patch (0.7 kB) - added by witt on 05/31/07 14:16:04.
libs-python-test-select_from_python_test_cpp.patch (0.9 kB) - added by witt on 05/31/07

Thomas Witt — Thu, 07 Jun 2007 18:12:11 GMT

Applied the following patches to RC_1_34_0:

boost-python-module_init_hpp.patch (1.8 kB) - added by witt on 05/31/07 14:11:32.

This makes aix_init_module.cpp obsolete. I did not remove it at this point as I don't want to mess with the build as such.

attachment set

Thomas Witt — Thu, 07 Jun 2007 18:43:02 GMT

attachment → boost-numeric-interval-detail-ppc_rounding_control_hpp.2.patch

Update patch per request from guillaume.melquiond@…

status, resolution changed

Thomas Witt — Thu, 07 Jun 2007 18:44:55 GMT

status new → closed
resolution None → fixed

Applied the following patches to RC_1_34_0:

boost-numeric-interval-detail-ppc_rounding_control_hpp.2.patch (0.7 kB) - added by witt on 06/07/07 14:43:02.

This was the last outstanding patch.

attachment set

Dave Abrahams — Fri, 08 Jun 2007 11:08:13 GMT

attachment → aix_init_module.patch

Removal of aix_init_module.cpp

status changed; resolution deleted

Dave Abrahams — Fri, 08 Jun 2007 11:16:53 GMT

status closed → reopened
resolution fixed

Patch enclosed to remove aix_init_module. The following files under libs/python should be cvs remove'd:

src/aix_init_module.cpp
example/Jamfile.v2
example/Jamrules
example/project.zip

I realize those last 3 are a separate issue technically, but they are each damaging in their own ways.

status changed; resolution set

Thomas Witt — Fri, 08 Jun 2007 18:42:16 GMT

status reopened → closed
resolution → fixed

Applied patch and removed src/aix_init_module.cpp from RC_1_34_0. The example/... files are not in RC_1_34_0.

status changed; resolution deleted

ccambly@… — Wed, 24 Oct 2007 20:03:27 GMT

status closed → reopened
resolution fixed

Many of these patches have not been applied to trunk. I will re-open attaching patches for the trunk branch.

attachment set

ccambly@… — Wed, 24 Oct 2007 20:04:38 GMT

attachment → boost_python.dsp.patch

Remove aix_init_module.cpp

attachment set

ccambly@… — Wed, 24 Oct 2007 20:05:51 GMT

attachment → date_generators.hpp.patch

date time generator fix. nth_as_str is used before it is declared.

attachment set

ccambly@… — Wed, 24 Oct 2007 20:07:19 GMT

attachment → function.hpp.patch

Preprocessor iteration was fixed in V8 on IBM XL compiler

attachment set

ccambly@… — Wed, 24 Oct 2007 20:08:09 GMT

attachment → Jamfile.v2.2.patch

Remove aix_init_module.cpp

attachment set

ccambly@… — Wed, 24 Oct 2007 20:09:31 GMT

attachment → module_init.hpp.patch

aix_init_module code is no longer required now that the libraries are built correctly. aix_init_module code has not worked since library tagging was added to Boost.Build.

attachment set

ccambly@… — Wed, 24 Oct 2007 20:10:41 GMT

attachment → ppc_rounding_control.hpp.patch

conflicting declarations from math.h

attachment set

ccambly@… — Wed, 24 Oct 2007 20:11:41 GMT

attachment → select_from_python_test.cpp.patch

Linker on LinuxPPC requires the definition of handle_execption_impl

attachment set

ccambly@… — Wed, 24 Oct 2007 20:27:33 GMT

attachment → operations.cpp.patch

readdir_r is not thread safe by default on AIX this is why the wide_test fails.

ccambly@… — Wed, 24 Oct 2007 21:14:32 GMT

All the patches have now been attached that we are interested in.

milestone changed

John Maddock — Thu, 01 Nov 2007 16:54:01 GMT

milestone Boost 1.34.1 → Boost 1.35.0

Steven Watanabe — Sat, 30 May 2009 00:06:41 GMT

Someone with access to this compiler needs to review these patches and split them up into one ticket per library.

viboes — Mon, 07 Jun 2010 09:23:04 GMT

I propose to close this ticket. If the reporter want to make a ticket by component/library these could be taken in account by the library maintainers. Otherwise no body will be able to close this ticket, as no body can apply all the patches.

Dave Abrahams — Mon, 07 Jun 2010 13:12:35 GMT

Alternatively, you could make a ticket for each component addressed by this patch and simply point it at this ticket. That would probably be a minimal and fairly mechanical job.

ccambly — Mon, 07 Jun 2010 17:00:37 GMT

Over a period of the last few years we have been adding each of these fixes as separate tickets. Michael and I are ok with closing this particular ticket. I will open an remaining issues directly against the library.

Jeremiah Willcock — Tue, 08 Jun 2010 19:14:55 GMT

The BGL patches in here are obsolete (they are to files that no longer exist).

status changed; resolution set

Marshall Clow — Fri, 18 Jun 2010 15:20:36 GMT

status reopened → closed
resolution → wontfix

Ok, then - I'm closing it.