Boost C++ Libraries: Ticket #5892: Why using pragma instead of fixing simple warnings?

Tue, 13 Sep 2011 01:18:32 GMT

Actually the issue is of course the combination of

boost/exception/detail/error_info_impl.hpp

and

boost/exception/info.hpp

Emil Dotchevski — Tue, 13 Sep 2011 02:53:18 GMT

<snip> This may seem cosmetic, but for the long term it could impact the overall quality if pragma proliferate and hide real issues.

In practice, it is impossible to "fix" all warnings on all platforms, plus some warnings fly in the face of conscious design decisions and thus can't be "fixed" without compromising the design. A "good" fix would be to disable specific warnings, but GCC does not support that. The only alternative is to disable all warnings, and rely on an extensive framework of tests to ensure correct behavior.

Emil

Tue, 13 Sep 2011 06:34:56 GMT

As I said, I do understand that it is not possible in all the cases.

But is there any guidelines about which warning should be fixed and which should be hidden?

boost/include/boost_1_41_0/boost/exception/info.hpp:28: error: declaration of 'value' shadows a member of 'this'

This one seems quite simple enough to fix.

Thanks, Christophe

Emil Dotchevski — Tue, 13 Sep 2011 18:05:42 GMT

I am trying to provide a warning-free experience for the user. If you see warnings, please provide compiler version and exact command line and I'll do my best to remove the warnings.

status changed; resolution set

Emil Dotchevski — Wed, 26 Oct 2016 18:54:56 GMT

status new → closed
resolution → wontfix