Boost C++ Libraries: Ticket #5905: Making switch matching on the result type of a transform

attachment set

Fri, 16 Sep 2011 12:59:53 GMT

attachment → new_switch.patch

patch_switch

Eric Niebler — Mon, 19 Sep 2011 21:43:55 GMT

Looks good. Some feedback. The biggest problem is the lack of changes to the reference docs for switch_ (see libs/proto/doc/reference/matches.xml), the missing new_switch.cpp test file, and the formatting that is inconsistent with the rest of Proto's source code. Note: I use 4-spaces for indenting.

Also, you can remove the specialization of switch_::impl in the primary switch_ template. It's still necessary in the specialization of switch_ for the default transform.

Thanks for your work on this!

attachment set

Thu, 22 Sep 2011 14:06:32 GMT

attachment → new_switch.2.patch

Thu, 22 Sep 2011 14:09:15 GMT

Hi Eric,

I modified the patch, you can find the new one in attached file. Please Let me know if I missed something again.

Thanks by advance ! Best,

Pierre

Eric Niebler — Thu, 22 Sep 2011 17:37:28 GMT

Thanks. Committed to trunk in [74513]. I'll keep an eye on the regression results and merge to release if it looks good.

status changed; resolution set

Eric Niebler — Fri, 23 Sep 2011 15:04:17 GMT

status new → closed
resolution → fixed

(In [74534]) merge [74470], [74481], [74513], [74527] from trunk; fixes #4723, #5905