Boost C++ Libraries: Ticket #5967: boost::archive::iterators::remove_whitespace do not work with pointers

status changed; resolution set

Robert Ramey — Sun, 02 Oct 2011 20:57:50 GMT

status new → closed
resolution → invalid

I'd have to see a small test case. Until that happens, I'm deleting this ticket.

Robert Ramey

cdubout@… — Sun, 02 Oct 2011 21:09:43 GMT

Replying to ramey:

I'd have to see a small test case. Until that happens, I'm deleting this ticket.

Robert Ramey

I could write a test case but it would really be a waste of time. Let me quote the source code of boost 1.47:

template<class Base>
class remove_whitespace :
    public filter_iterator<
        remove_whitespace_predicate<BOOST_DEDUCED_TYPENAME Base::value_type>,

If base is a pointer as opposed to an iterator class, there will be a compilation error since Base is not a class, and do not contain a value_type. There might be an easy workaround, but so far I did not find how to use remove_whitespace directly on C strings. Regards,

Charles

status changed; resolution deleted

cdubout@… — Sun, 02 Oct 2011 21:28:37 GMT

status closed → reopened
resolution invalid

Robert Ramey — Sat, 08 Oct 2011 04:29:20 GMT

lol - OK - I see your argument. But without a test case, how will I know for sure that I fixed it?

Would you care to submit a test and patch?

I believe that this could be addressed by altering the code to use boost::iterator_traits (see ../libs/iterator/doc/iterator_traits.html). Now that you've pointed this out, it's possible that other members of this group suffer the same deficiency.

Any help you might be able to contribute would be appreciated.

Robert Ramey

Robert Ramey — Sat, 08 Oct 2011 05:05:27 GMT

try altering remove_whitespace.hpp to include:

#include <boost/iterator/iterator_traits.hpp>

remove_whitespace_predicate<

BOOST_DEDUCED_TYPENAME boost::iterator_value<Base>::type BOOST_DEDUCED_TYPENAME Base::value_type

,

Let me know how this works

Robert Ramey

status changed; resolution set

Robert Ramey — Tue, 18 Feb 2014 18:22:08 GMT

status reopened → closed
resolution → fixed

Got no response.

I think I fixed this last april '13 So I'm closing this ticket.

Robert Ramey