Boost C++ Libraries: Ticket #6013: endian.hpp header patch to utilize OpenBSD's endian header

attachment set

brad@… — Wed, 12 Oct 2011 06:59:36 GMT

attachment → patch-boost_detail_endian_hpp

anonymous — Tue, 08 Nov 2011 16:01:27 GMT

Which Boost library (component) are you using that needs this patch?

brad@… — Tue, 08 Nov 2011 16:15:46 GMT

The same code that uses this header in the first place.

component changed; owner set

viboes — Mon, 12 Dec 2011 22:42:12 GMT

owner set to chris_kohlhoff
component None → asio

anonymous — Tue, 13 Dec 2011 00:54:26 GMT

How is this related to asio?

brad@… — Thu, 22 Nov 2012 04:31:43 GMT

ping.

attachment set

riz@… — Thu, 24 Jan 2013 21:59:35 GMT

attachment → endian.patch

Updated BSD patch for boost/detail/endian.hpp

riz@… — Thu, 24 Jan 2013 22:02:27 GMT

I recently tried building something using Boost on NetBSD/arm using boost 1.52, and it failed because it couldn't detect the endianness properly. I see that in the trunk there is testing against ARMEL and ARMEB, but the proper way to fix it is to use sys/endian.h (or, I guess, machine/endian.h under OpenBSD).

The updated patch should be correct for NetBSD, FreeBSD, OpenBSD, and DragonFlyBSD.

brad@… — Thu, 31 Jan 2013 11:43:30 GMT

That looks good to me.

brad@… — Sun, 10 Feb 2013 00:41:03 GMT

Any chance of getting a review of the pending patch?

brad@… — Mon, 11 Feb 2013 20:21:33 GMT

riz:

Actually looking at that diff again there is a mistake in it.

The line.. "+# define BOOST_BYTE_ORDER BYTE_ORDER" should be using _BYTE_ORDER not BYTE_ORDER.

attachment set

brad@… — Tue, 12 Feb 2013 16:55:56 GMT

attachment → boost_endian.diff

Updated BSD patch for boost/detail/endian.hpp

brad@… — Tue, 12 Feb 2013 16:58:05 GMT

Here is an updated diff with the issue I mentioned above fixed.

owner changed

John Maddock — Tue, 19 Feb 2013 11:58:46 GMT

owner changed from chris_kohlhoff to John Maddock

John Maddock — Tue, 19 Feb 2013 11:59:30 GMT

(In [82996]) Apply BSD patch. Refs #6013.

component changed

John Maddock — Tue, 19 Feb 2013 13:09:33 GMT

component asio → config

brad@… — Tue, 19 Feb 2013 15:06:38 GMT

John, Thank you for commiting this.

status changed; resolution set

John Maddock — Sun, 24 Feb 2013 19:08:04 GMT

status new → closed
resolution → fixed

(In [83139]) Merge changes from Trunk. Fixes #6013. Fixes #7151. Fixes #7359. Fixes #7389. Fixes #7452. Fixes #7528. Fixes #7703. Fixes #7841. Fixes #7898. Fixes #7938. Fixes #8048.