status changed; resolution set

Gennadiy Rozental — Mon, 05 Nov 2012 10:29:36 GMT

status new → closed
resolution → fixed

Fixed in trunk by 81197

Mon, 04 Mar 2013 18:01:29 GMT

Hi rogeeff,

I checked out trunk and still see the following warnings when building release in VS2012 (original reporter talked about VS2010):

boost\test\utils\named_params.hpp(75): warning C4702: unreachable code
boost\test\utils\named_params.hpp(79): warning C4702: unreachable code
boost\test\utils\named_params.hpp(87): warning C4702: unreachable code

I got rid of them by removing the code after throwing exception (not sure if it's OK for other compilers):

Against trunk revision 81197:

line 75: { report_access_to_invalid_parameter(true); /*static T* v = 0; return *v;*/ }
line 79: { report_access_to_invalid_parameter(true); /*static typename remove_reference<T>::type* v = 0; return *v;*/ }
line 83: { report_access_to_invalid_parameter(true); /*return nil();*/ }
line 87: { report_access_to_invalid_parameter(true); /*return nil();*/ }
line 91: { report_access_to_invalid_parameter(true); /*return nil();*/ }

Against boost 1.53:

line 74: { report_access_to_invalid_parameter(); /*static T* v = 0; return *v;*/ }
line 78: { report_access_to_invalid_parameter(); /*static typename remove_reference<T>::type* v = 0; return *v;*/ }
line 82: { report_access_to_invalid_parameter(); /*return nil();*/ }
line 86: { report_access_to_invalid_parameter(); /*return nil();*/ }
line 90: { report_access_to_invalid_parameter(); /*return nil();*/ }

Tue, 05 Mar 2013 15:03:09 GMT

The fix above breaks the build in debug mode :) I fixed both modes by removing function report_access_to_invalid_parameter() and throwing exception directly in 6 occurrences (including line 282/281):

{ throw access_to_invalid_parameter(); }

milestone changed

Raffi Enficiaud — Tue, 07 Jul 2015 08:29:48 GMT

milestone To Be Determined → Boost 1.59.0

I believe this is fixed.

Boost C++ Libraries: Ticket #6074: warnings-as-errors not usable with Boost.test in release mode

status changed; resolution set

milestone changed