Boost C++ Libraries: Ticket #6165: BOOST_ENABLE_THREADS/BOOST_DISABLE_THREADS wrongly configured on GCC 4.7

attachment set

Wed, 23 Nov 2011 08:39:06 GMT

attachment → libstdcpp3.hpp.patch

status changed; resolution set

John Maddock — Sat, 24 Dec 2011 16:19:44 GMT

status new → closed
resolution → fixed

(In [76133]) Fix threading detection in GCC-4.7 experimental. Fixes #6165.

bkoz@… — Tue, 10 Jan 2012 00:20:34 GMT

For 4.7, this is

# if defined(_GLIBCXX_HAS_GTHREADS)

For 4.6 and others, this should be

# if defined(_GLIBCXX_HAVE_GTHR_DEFAULT) \

defined(_GLIBCXXPTHREADS)

attachment set

t.sailer@… — Sat, 14 Jan 2012 19:34:37 GMT

attachment → boost-1.48.0-gcc47-winthreads.patch

Threading Detection fix for gcc 4.7/mingw32 target

status changed; resolution deleted

t.sailer@… — Sat, 14 Jan 2012 19:38:34 GMT

status closed → reopened
resolution fixed

The threading detection doesn't yet work for gcc 4.7 with the mingw32 target.

mingw32 gcc defines (for some time already) GLIBCXX. Up to 4.6, it used to define _GLIBCXX_HAVE_GTHR_DEFAULT as well, that's why it worked up to 4.6.

Now 4.7 no longer defines _GLIBCXX_HAVE_GTHR_DEFAULT, which prevents threading from compiling.

raptorfactor@… — Mon, 16 Jan 2012 04:11:11 GMT

The Fedora project is using the following workaround/fix:

http://pkgs.fedoraproject.org/gitweb/?p=mingw32-boost.git;a=blob;f=boost-1.48.0-gcc47-winthreads.patch

raptorfactor@… — Mon, 16 Jan 2012 04:21:37 GMT

Oops, I just noticed Thomas has already posted it. Durrr. Sorry for the noise.

anonymous — Mon, 16 Jan 2012 09:41:08 GMT

What does bits/c++config.h do to detect when it's being build with --enable-threads ? There must be some such macro even if it's name has changed?

Thanks, John.

t.sailer@… — Mon, 16 Jan 2012 12:51:19 GMT

Interestingly, I do not have bits/c++config.h in my mingw32 gcc installation.

gcc defines _MT if -mthreads is given on the command line (and that is the only difference).

anonymous — Tue, 17 Jan 2012 13:14:46 GMT

gcc defines _MT if -mthreads is given on the command line (and that is the only difference).

I'm not convinced that's the right thing to check - ideally what we want to know is "what configure options was libstdc++ compiled with?", and then set BOOST_HAS_THREADS uniformly based on that.

Can someone please grep the headers for _GLIBCXX_HAS_GTHREADS: there should be a preprocessor based switch statement somewhere that selects which threading behaviour to use, and that's what we need to hook into.

Thanks, John.

t.sailer@… — Tue, 17 Jan 2012 13:21:48 GMT

$ find /usr/lib64/gcc/i686-pc-mingw32/4.7.0/include /usr/i686-pc-mingw32/sys-root/mingw/include/ |xargs grep _GLIBCXX_HAS_GTHREADS /usr/lib64/gcc/i686-pc-mingw32/4.7.0/include/c++/i686-pc-mingw32/bits/c++config.h:/* #undef _GLIBCXX_HAS_GTHREADS */ /usr/lib64/gcc/i686-pc-mingw32/4.7.0/include/c++/thread:#if defined(_GLIBCXX_HAS_GTHREADS) && defined(_GLIBCXX_USE_C99_STDINT_TR1) /usr/lib64/gcc/i686-pc-mingw32/4.7.0/include/c++/thread:#endif _GLIBCXX_HAS_GTHREADS && _GLIBCXX_USE_C99_STDINT_TR1 /usr/lib64/gcc/i686-pc-mingw32/4.7.0/include/c++/mutex:#if defined(_GLIBCXX_HAS_GTHREADS) && defined(_GLIBCXX_USE_C99_STDINT_TR1) /usr/lib64/gcc/i686-pc-mingw32/4.7.0/include/c++/mutex:#endif _GLIBCXX_HAS_GTHREADS && _GLIBCXX_USE_C99_STDINT_TR1 /usr/lib64/gcc/i686-pc-mingw32/4.7.0/include/c++/condition_variable:#if defined(_GLIBCXX_HAS_GTHREADS) && defined(_GLIBCXX_USE_C99_STDINT_TR1) /usr/lib64/gcc/i686-pc-mingw32/4.7.0/include/c++/condition_variable:#endif _GLIBCXX_HAS_GTHREADS && _GLIBCXX_USE_C99_STDINT_TR1 /usr/lib64/gcc/i686-pc-mingw32/4.7.0/include/c++/future:#if defined(_GLIBCXX_HAS_GTHREADS) && defined(_GLIBCXX_USE_C99_STDINT_TR1) \ /usr/lib64/gcc/i686-pc-mingw32/4.7.0/include/c++/future:#endif _GLIBCXX_HAS_GTHREADS && _GLIBCXX_USE_C99_STDINT_TR1

I can't find any definition.

t.sailer@… — Tue, 17 Jan 2012 13:28:08 GMT

/usr/lib64/gcc/i686-pc-mingw32/4.7.0/include/c++/i686-pc-mingw32/bits/c++config.h has:

/* Define if gthreads library is available. */ /* #undef _GLIBCXX_HAS_GTHREADS */

/* Define if pthreads_num_processors_np is available in <pthread.h>. */ /* #undef _GLIBCXX_USE_PTHREADS_NUM_PROCESSORS_NP */

/* Define to 1 if mutex_timedlock is available. */ #define _GTHREAD_USE_MUTEX_TIMEDLOCK 1

I can't find anything else thread-related in there...

Is it even possible to not have threading on Win32?

status changed; resolution set

John Maddock — Fri, 20 Jan 2012 17:36:29 GMT

status reopened → closed
resolution → fixed

(In [76594]) Enable thread support unconditionally on Win32 - it's not clear that this is the right thing to do, but it does seem to be needed for gcc-4.7 on Mingw and Cygwin. Fixes #6165.

pwouters@… — Mon, 23 Jul 2012 21:41:56 GMT

It seems to still be broken on fedora with boost-1.48.0-13

anonymous — Tue, 24 Jul 2012 08:05:18 GMT

The patch was first released in 1.49.0.